TEXT_JUSTIFY_R0

[boyan]

TEXT_JUSTIFY_R0

[boyan]

starting analysis

[boyan]

finished analysis (0.25d)

[boyan]

restarted analysis

[boyan]

restarting analysis

[boyan]

analysis finished (0.5d total)

[boyanl]

The analysis is clear and sufficient for the task.

[boyanl]

• Changes to the HotSegmentLayout class:
  • Add an Integer[] wordPos field to represent the start positions of what we consider "words" (for justification, we want only whitespace-separated words)
  • Add a double textWidth to show the width of the text in the segment
  • In HotSegmentLayout.create add logic that passes the correct wordPos and textWidth to the constructor. We fill the positions array when we're parsing the words in the text
  • Add a boolean lastInParagraph argument to HotSegmentLayout.create to show whether the text we're constructing the layout from is a last line in its paragraph (if so, we don't need to get the justified layout)
  • In HotSegmentLayout.getJustifiedLayout return a properly-spaced layout. The algorithm is as follows - for each TextRun starting at a position present in the wordPos field, we translate its X-coordinate in the locations array by the average amount needed per word (we get the average amount by calculating the remaining width and dividing it by the number of words).
• Changes to the HotLineLayout class:
  • In HotLineLayout.create add a parameter lastLineInPara to indicate whether the text we're creating the layout from is a last line in its paragraph.
• Changes to HotAreaLayout class:
  • In HotAreaLayout.create pass the correct value of lastLineInPara to the HotLineLayouts
• Changes to the LayoutUtils class:
  • In the LineIterator.nextLine method append the following para-break to the returned line (if there is any)
• Changes to the LineBreakUtil class:
  • In Word.get add a parameter List<Integer> whitespaceBreaks, which is filled with the positions of characters after consecutive whitespaces. (used in HotSegmentLayout ). It also can be null.
• Changes to the TextUtils class:
  • Small fixes to findNextChar and findPrevChar that cause problems when you change style at the end of the text.
• Changes to the TextModelLogic class
  • Add additional logic when handling LINE_END event - should skip trailing paragraph breaks (for proper positioning when you want to go at the end of line, since we want para breaks to be at the end of lines now)
• Also in TextModelLogic.handleMouseEvent and in Breaks.getNextCharacterPos fix a small bug with word spacing when you have trailing separators till the end of the text

[kyli]

• Generally seems ok but
• First it is better to use int instead of Integer
• It would be nice if line and respectively segment layouts weren't recreated so much because of PARA_BREAK ending lines.
• Actually the justification is done per segment and not per line as is the requirement of the task. But this seems acceptable...
• "fix a small bug" doesn't look like a design.
• And looking at your code it could be written more readable.
  • No "boolean a = val1, b = val2".
  • Variable assignment inside loop and if statement's condition.

3.5p.

[boyanl]

• Fixed the recreation of layouts but changed the behavior a bit (only the last segment is left-aligned as opposed to the whole line, but this doesn't contradict the analysis)

[pap]

• Commited in [9155].
• If you declare and initialize variables do this on separate lines.
• Always write braces for the bodies of conditional and loop statements. This is a serious rule. Otherwise it is too easy to produce errors.

[meddle]

Closing all the tickets before M Y1