Ticket #244 (closed planned_task: obsolete)
BASE_DIALOGS_R0
Reported by: | Astea | Owned by: | pavlina |
---|---|---|---|
Priority: | 3 | Milestone: | M02b_PRE2b |
Component: | BASE_GUI_LIB | Version: | 2.0 |
Keywords: | Cc: | ||
Category: | unknown | Effort: | 0.5 |
Importance: | 20 | Ticket_group: | |
Estimated Number of Hours: | Add Hours to Ticket: | ||
Billable?: | Total Hours: | ||
Analysis_owners: | tanya | Design_owners: | pav |
Imp._owners: | pav | Test_owners: | |
Analysis_reviewers: | pap | Changelog: | |
Design_reviewers: | pap | Imp._reviewers: | pap,pap |
Test_reviewers: | Analysis_score: | 3.5 | |
Design_score: | 3.5 | Imp._score: | 3 |
Test_score: | 0 |
Description
wiki page: BASE_DIALOGS_R0 - effort: 0.5d
Change History
comment:1 Changed 16 years ago by todor
- Owner changed from Astea to todor
- Status changed from new to analyzing
comment:4 Changed 16 years ago by pavlina
- Owner changed from todor to pavlina
- Status changed from analysis_accepted to designing
comment:6 Changed 16 years ago by pap
- Status changed from designed to design_accepted
Review: 3.5. OK
comment:7 Changed 16 years ago by deyan
- Status changed from design_accepted to s2c_design_ok
repairing from invalid state
comment:8 Changed 16 years ago by pavlina
- Status changed from s2c_design_ok to s3a_implementation_started
comment:9 Changed 16 years ago by pavlina
- Status changed from s3a_implementation_started to s3b_implementation_finished
done:2h
comment:10 Changed 16 years ago by deyan
- Milestone changed from M02_PRE2 to M02b_PRE2b
Milestone change
comment:11 Changed 16 years ago by pap
- Status changed from s3b_implementation_finished to s2c_design_ok
- Analysis_score set to 0
- Test_score set to 0
- Imp._reviewers set to pap
- Design_score set to 0
- Imp._score set to 2
You haven't deleted the Activator class
I think that it's a better idea to just make a mock dialog with mock input and output and a mock dialog without such, than making a mock about dialog and mock file dialog.
comment:12 Changed 16 years ago by pavlina
- Design_owners set to Pavlina
- Design_score changed from 0 to 3.5
- Imp._owners set to Pavlina
comment:13 Changed 16 years ago by pavlina
- Status changed from s2c_design_ok to s3a_implementation_started
comment:14 Changed 16 years ago by pavlina
- Status changed from s3a_implementation_started to s3b_implementation_finished
1h
comment:15 Changed 16 years ago by pap
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 2 to 3
- Imp._reviewers changed from pap to pap,pap
Implementation section of the wiki page could've been a bit more explanatory.
I think you should have used DummyInput and DummyOutput in mocking. Also I find it quite hard to understand the DialogManager unit test, especially as it is without any JavaDoc
comment:18 Changed 16 years ago by pap
- Category set to unknown
- Design_reviewers set to pap
- Analysis_reviewers set to pap
- Analysis_score changed from 0 to 3.5
setting custom fields
comment:19 Changed 16 years ago by deyan
- Design_owners changed from Pavlina to pav
- Imp._owners changed from Pavlina to pav
Batch update from file newimport.csv
comment:20 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv