skinning-themes -- Implement skinning in Sophie

[deyan]

Implement themes

• See behavior in Skinning/Themes
• Create a sample theme to show the capabilities of theme skins

[tanya]

• The task is to provide the functionality to change the theme by setting values to the ids via a file.
• No new skin ids will be added.
• At this moment, the types for theme can be - boolean, integer, icon, iconset, color, size, point. Only for them value loaders will be created.

[tanya]

• In the SkinManager class
  • Singleton method is created to return an instance of the default theme pack.
  • Singleton method is created to return an instance of the default interaction pack.
  • 2 constants added - SkinManager.THEME_PACK_NAME and SkinManager.INTERACTION_PACK_NAME. These constants are for the default packs of the skin - for theme pack and interaction pack.
  • 2 ConfigKeys added - CURRENT_THEME_SKIN and CURRENT_INTERACTION_SKIN.
  • The constant DEFAULT_NAME is removed.
  • Now there is no default pack. Now we have 3 packs - language, theme, intearction.
  • Property currentSkin() is removed. Two new properties are added - currentThemePack() and currentInteractionPack().
• In the SkinUtil class
  • getSkinValues method is fixed - now getSkinValues searches only in the currentSkin(). It should search in the currentLanguagePack() or in some other current pack depending on the value class.
• In the org.sophie2.base.commons module and the org.sophie2.base.commons.gui package new class added - MenuMemberMnemonic. Wrapper class for mnemonics. Its objects will be set as mnemonic for different MenuMembers. It will have one method getMnemonic():Integer. Now the mnemonic property of the MenuMember returns MenuMemberMnemonic and using getMnemonic() method we get integer which is the mnemonic itself.
• In BaseSkinModule class the field that is the instance of the SkinValueLoader extension point is renamed from skinEntryValuePoint to skinValueLoaderPoint.
• SkinUtil.getSkinValue method fixed. Code duplication reduced.
• SkinUtil.getSkinValues is changed to get values from the appropriate skin (depending on the value class).
• JavaDoc of the SkinPartsProvider fixed.
• JavaDoc of the SkinValueLoader fixed.
• SkinManager.createSkin changed to return the None value if skinDef is null.
• New method is created in ImageUtil class - loadIconByPath(String iconPath) : ImmImage. It loads an icon by given path (the path to the icon). The existing method loadIcon is refactored to use loadIconByPath. The path to the icon is the absolute path to the icon according to the distrib directory of the application.

[pap]

• CURRENT_THEME_SKIN and CURRENT_INTERACTION_SKIN would better be called PACK
• MenuMemberMenmonic class should be renamed as it isn't only for menus, I think :)
• PointValueLoader -> ImmPointValueLoader ?? Beacuse Point is a class from the AWT.
• I still cannot understand why do you use "extension" and "extension point" in JavaDoc of classes and interfaces. They are used through that mechanism, but this doesn't make them such. MyTypeValueLoader loads MyType values from skin files no matter whether it is used through the EPs and Es.
• IconValueLoaderUtil - I think that you don't need that.
• Why have you written three separate properties for synchronization. Use three @Setup methods in one property.
• Not that it really matters but in the SkinUtil it is better to get the current pack, search in it and if no result is found then get the default pack. And not as you do get the default no matter whether it is needed.

[pap]

• Also don't forget to give an example skin and to explain the formats of all the supported types. Without such information the theme is almost useless.
• Also we need the SkinRecordId-s of the SkinRecords that can be changed. It would be good if you give an idea about that :)

[tanya]

[9240] in /branches/tanya/blackSkin

Formats of the values added to http://sophie2.org/trac/wiki/Skinning/Themes

[meddle]

Closing all the tickets before M Y1