Ticket #2447 (closed bug: obsolete)
auto-actions-named-classes--main.app.halos
| Reported by: | diana | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | uncategorized | Version: | 2.0 |
| Keywords: | auto_actions | Cc: | |
| Category: | unknown | Effort: | |
| Importance: | Ticket_group: | ||
| Estimated Number of Hours: | 0 | Add Hours to Ticket: | 0 |
| Billable?: | yes | Total Hours: | 0 |
| Analysis_owners: | diana | Design_owners: | diana |
| Imp._owners: | diana | Test_owners: | |
| Analysis_reviewers: | pap | Changelog: | Changelog |
| Design_reviewers: | pap | Imp._reviewers: | deyan, pap |
| Test_reviewers: | Analysis_score: | 3.5 | |
| Design_score: | 3.5 | Imp._score: | 3.5 |
| Test_score: | 0 |
Description
- Extract all the anonymous classes from main.app.halos module of type AutoAction in named classes in main.app.halos.actions module.
Attachments
Change History
comment:2 Changed 15 years ago by diana
- Status changed from s1b_analysis_finished to s2a_design_started
comment:3 Changed 15 years ago by diana
- Status changed from s2a_design_started to s3b_implementation_finished
- Extracted classes:
AlignElementsAction, ChangeBgImageAction, ChangeBgOpacityAction,
ChangeBorderColorAction, ChangeFrameBorderColorAction,
ChangeFrameVisibilityAction, ChangeFrameZOrderAction,
DeleteGroupAction, DeleteGroupResourceAction, GroupElementsAction,
LockAction, LockTemplateAction, SetBgColorAndTypeAction,
SetBgGradientAndTypeAction, SetBgTypeAction, SetBorderColorAction,
SetBorderInsetsAction, SetFrameContentTemplAction, SetLocationAction, SetPageSizeAction, SetShadowColorAction,
SetShadowEnabledAction, SetShadowOffsetAction, SetShadowOpacityAction, SetWrapModeAction, UseTemplateAction
comment:4 Changed 15 years ago by pap
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Analysis_reviewers set to pap
- Analysis_score changed from 0 to 3.5
- Imp._reviewers set to deyan, pap
- Design_score changed from 0 to 3.5
- Design_reviewers set to pap
- Imp._score changed from 0 to 3.5
- Commited to trunk in [9172] and [9173].
- The analysis is OK
- The design is good, but you extracted several actions that you could've reused.
- Also you forgot to extract one action about background images and you didn't mention the rotation actions that were left.
- The implementation is ok, but you could've used some variables to make shorter lines. And some of the JavaDoc was misleading :)
Note: See
TracTickets for help on using
tickets.
