Ticket #248 (closed planned_task: obsolete)
BASE_HALOS_R1
| Reported by: | Astea | Owned by: | peko |
|---|---|---|---|
| Priority: | 3 | Milestone: | M06_ALPHA1 |
| Component: | BASE_GUI_LIB | Version: | 2.0 |
| Keywords: | Cc: | peko | |
| Category: | BASE | Effort: | 3 |
| Importance: | 0 | Ticket_group: | GROUP_BASE_HALOS_AND_FRAME_POSITION_R1 |
| Estimated Number of Hours: | Add Hours to Ticket: | ||
| Billable?: | Total Hours: | ||
| Analysis_owners: | deyan | Design_owners: | peko |
| Imp._owners: | Test_owners: | ||
| Analysis_reviewers: | meddle, dido | Changelog: | |
| Design_reviewers: | pap, meddle | Imp._reviewers: | |
| Test_reviewers: | Analysis_score: | 4.5 | |
| Design_score: | 2 | Imp._score: | 0 |
| Test_score: | 0 |
Description
wiki page: BASE_HALOS_R1 - effort: 3d
Change History
comment:1 Changed 16 years ago by sriggins
- Status changed from new to s1a_analysis_started
- Analysis_score set to 0
- Test_score set to 0
- Design_score set to 0
- Owner changed from Astea to sriggins
- Imp._score set to 0
- Analysis_owners set to sriggins
comment:2 Changed 16 years ago by sriggins
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:3 Changed 16 years ago by meddle
- Cc sriggins added
- Status changed from s1b_analysis_finished to new
- Analysis_reviewers set to meddle
- Analysis_score changed from 0 to 1
This task is with 3 effort. There are many things that need to be done with the halos/huds, not only the overlapping issue, for example:
- The halos should be made to use the MVCR3. There should not be userClick method
- HUD refactoring is part of this task too. For example its size should be calculated depending on the visible controls in it.
- The models of the halos/huds should be accessed cleanly because now it is accessed differently and ugly for all the halos/huds.
- The code quality of the halo/hud code should be improved.
- Some code is redundant and can be deleted/replaced.
Or other alternative is to create a special ticket that is only for the overlapping issue and to work on it... That ticket would be bug or unplanned task, you can discuss with deyan that.
Other thing. I took a look at your design/implementation. Even for a bugfix the design should be more detailed, can contain sample code, if you add new functionality (for example your method) you will have to add tests for it. The implementation idea in the analysis section is not the design itself!
And the idea of our process is first to write analysis, when accepted write good design with sample code when posiible/UML diagrams when you add new object models/good tests that make sure your design code works according to the design when implemented, and then if the design is accepted implementation.
1p (40m)
comment:5 Changed 16 years ago by deyan
- Cc deyan added; sriggins removed
Halos should lay out in a halo menu. Halo menu should be the frame title bar. a contents halo should be inside the frame, where the user has clicked.
comment:7 Changed 16 years ago by deyan
- Owner changed from sriggins to deyan
- Status changed from new to s1a_analysis_started
comment:8 Changed 16 years ago by deyan
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:9 Changed 16 years ago by dido
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers changed from meddle to meddle, dido
- Analysis_score changed from 1 to 4.5
Analysis review 4.5p (30m)
comment:10 Changed 16 years ago by peko
- Design_owners set to peko
- Owner changed from deyan to peko
- Status changed from s1c_analysis_ok to s2a_design_started
comment:11 Changed 16 years ago by peko
- Status changed from s2a_design_started to s2b_design_finished
comment:12 Changed 16 years ago by pap
- Cc peko added; deyan removed
- Design_score changed from 0 to 2
- Design_reviewers set to pap, meddle
- Status changed from s2b_design_finished to s1c_analysis_ok
- About the ContentHaloMenu - I think that you may make it an abstract class in the main.app.halos module and redefine its parent() property as FrameContentView
- The buttons property of the HaloMenu class is readonly so you cannot modify it.
- The alignment was states as a requirement in the analysis so it should be designed
- The test given seems very sad.
comment:15 Changed 16 years ago by peko
- Status changed from s2a_design_started to s2b_design_finished
comment:16 Changed 15 years ago by deyan
- Status changed from s2b_design_finished to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
