Ticket #255 (closed planned_task: obsolete)

Opened 11 years ago

Last modified 10 years ago

BASE_BOUND_CONTROLS_R1

Reported by: Astea Owned by: sveto
Priority: 3 Milestone: M07_ALPHA2
Component: BASE_GUI_LIB Version: 2.0
Keywords: Cc: sveto
Category: BASE Effort: 3
Importance: 0 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: pap,meddle, velizar Design_owners: mitex, velizar
Imp._owners: sveto, sveto, sveto Test_owners:
Analysis_reviewers: dido Changelog:
Design_reviewers: meddle, meddle, tanya Imp._reviewers: meddle, meddle, meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3
Test_score: 0

Description

wiki page: BASE_BOUND_CONTROLS_R1 - effort: 3d

Change History

comment:1 Changed 11 years ago by pap

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to pap
  • Imp._score set to 0
  • Analysis_owners set to pap,meddle

taken for analysis

comment:2 Changed 11 years ago by pap

  • Status changed from s1a_analysis_started to s1b_analysis_finished

Finished analysis in 40m.

comment:3 Changed 11 years ago by dido

  • Analysis_reviewers set to dido

comment:4 Changed 11 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

comment:5 Changed 11 years ago by meddle

  • Analysis_score changed from 0 to 4

comment:6 Changed 11 years ago by pap

  • Design_owners set to meddle
  • Status changed from s1c_analysis_ok to s2a_design_started

Taken for design

comment:7 Changed 11 years ago by mitex

  • Design_owners changed from meddle to mitex

comment:8 Changed 11 years ago by velizar

  • Status changed from s2a_design_started to new

comment:9 Changed 11 years ago by velizar

  • Owner changed from pap to velizar
  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from pap,meddle to pap,meddle, velizar

comment:10 Changed 11 years ago by velizar

  • Analysis_score changed from 4 to 0

comment:11 Changed 11 years ago by velizar

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:12 Changed 11 years ago by dido

  • Status changed from s1b_analysis_finished to new
  • Analysis_score changed from 0 to 2.5

Almost there. The analysis is good but here is a list of problems in this analysis some of them are small other not so small:

  • Missing goal - There should be some overview of the task that explains what this task is all about.
  • Task requirements - hard to read actually, please format the wiki properly. Use sub bullets for sub list items instead of + sign
    • This line here - Change the hierarchy so that the icon of the state can be dropped (controls should be able to chose whether with such an icon or without it). I guess instead of dropped - optional will be more appropriate
    • This is not for this section - The listener should be attached not to the whole panel, but rather to the color rectangle which may become a "ButtonBoundControl".
  • Implementation idea is empty - Lets mention the ideas in this section, not in requirements.
  • Provide more detailed "How to demo" section. For example show the new controls in action or something.
  • Please format the links in related section by putting each link in new line
  • Finally if this is part of GROUP_GUI_REDESIGN_R0 shouldn't it include rescinning and customizing for all controls or it's not going to be implemented on this revision.

Analysis reviewed 2.5p (40m)

comment:13 Changed 11 years ago by velizar

  • Status changed from new to s1a_analysis_started

Reskinning is not part of this task.

comment:14 Changed 11 years ago by velizar

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:15 Changed 11 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 2.5 to 3

Analysis review 4p (20m)

comment:16 Changed 11 years ago by velizar

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:17 Changed 11 years ago by velizar

  • Design_owners changed from mitex to mitex, velizar

comment:18 Changed 11 years ago by velizar

  • Status changed from s2a_design_started to s2b_design_finished

comment:19 Changed 11 years ago by meddle

  • Status changed from s2b_design_finished to new
  • Design_reviewers set to meddle
  • Analysis_score changed from 3 to 0

I'm failing the task and postponing it for the next week.

  • Now you can do that, write test and write tickets for these three bugs/tweak:
    • The JText bound fix
    • The Slider tweak
    • The ZOOM bug
  • The next week this task will be yours and will have requirements like that (talk with tanya, me, pap and peko for details)
    • LogicR3 in all bounds.
    • Cleaner layout (think of a good design)
    • Fix ComboBox bound control
    • Remake the Spinner bound control
    • Think of more...

(1h)

comment:20 Changed 11 years ago by velizar

  • Status changed from new to s1a_analysis_started

comment:21 Changed 11 years ago by velizar

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:22 Changed 11 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 0 to 3.5

It's fine good luck.
Analysis reviewed 3.5p (30m)

comment:23 Changed 11 years ago by dido

  • Cc velizar, dido added

comment:24 Changed 11 years ago by velizar

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:25 Changed 11 years ago by velizar

  • Status changed from s2a_design_started to s2b_design_finished

comment:26 Changed 11 years ago by meddle

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2

I have the following notes:

  • First of all write the tests for the Logic and the Combo
  • ROW, COLUMN и SQUARE are ok, but you must be sure in their behavior... I mean ROW is different from FLOW, which must be added too(the current behavior is this -> FlowLayout). SQUARE must have an argument where to position the label (LEFT, RIGHT, CENTER). --Peko

2p (30m)

comment:27 Changed 11 years ago by velizar

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:28 Changed 10 years ago by velizar

  • Status changed from s2a_design_started to s2b_design_finished

comment:29 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2 to 3.5
  • Design_reviewers changed from meddle to meddle, meddle, tanya

*"If validation for some group of bound controls is not necessary, the first member should be omitted." -> That's not true, In that case the first member -> PROCEED_VALIDATION will always declare the validation as successful but will be not omitted.

  • There must be no "System.out"s in the code for review!
  • You tried to have good tests, I'm happy :)

3.5p (20m)

comment:30 Changed 10 years ago by velizar

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:31 Changed 10 years ago by sveto

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Total Hours set to 0
  • Imp._owners set to sveto
  • Add Hours to Ticket set to 0
  • Billable? set
  • Estimated Number of Hours set to 0

comment:32 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 2
  • Imp._reviewers set to meddle

You have two BIG problems:

  • Your code could not be build with maven.
  • You broke the combo box: BUG
    • on one frame open the background hud, choose to change the gradient background
    • Choose radial on the combo box... it changes.
    • On another frame pen the background hud, choose to change the gradient background
    • Choose radial on the combo box... it doesn't change and you can not change it in the future on no frame...

2p (30m)

comment:33 Changed 10 years ago by sveto

  • Owner changed from velizar to sveto
  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners changed from sveto to sveto, sveto

comment:34 Changed 10 years ago by sveto

  • Status changed from s3a_implementation_started to s3b_implementation_finished

(10h)

comment:35 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 2 to 2.5
  • Imp._reviewers changed from meddle to meddle, meddle

The bound controls don't work under the reader (try the zoom combo box)... So I'll fail this task...

2.5p (1h)

comment:36 Changed 10 years ago by sveto

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners changed from sveto, sveto to sveto, sveto, sveto

comment:37 Changed 10 years ago by sveto

  • Status changed from s3a_implementation_started to s3b_implementation_finished

(3.5h)

comment:38 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2.5 to 3
  • Imp._reviewers changed from meddle, meddle to meddle, meddle, meddle

I'll pass this task but I will not merge it to the trunk. In the future parts of it will be integrated to the redesign code...

  • I don't like these sort keys, which are your fix for the reader.
  • You had to fix all the bad code in the bounds' module and you didn't do it...
  • The validation logic will stay as before when we integrate it, because there are some problems with the current implementation (you can write bound without writing validation logic and this approach leads to copy-paste code...)

3p (2h)

comment:39 Changed 10 years ago by meddle

  • Cc sveto added; velizar, dido removed

comment:40 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.