Ticket #268 (closed planned_task: obsolete)
SCENE_AUDIO_POINT_R0
| Reported by: | Astea | Owned by: | Tanya |
|---|---|---|---|
| Priority: | 3 | Milestone: | M02b_PRE2b |
| Component: | BASE_SCENE | Version: | 2.0 |
| Keywords: | Cc: | ||
| Category: | unknown | Effort: | 0.5 |
| Importance: | 20 | Ticket_group: | |
| Estimated Number of Hours: | Add Hours to Ticket: | ||
| Billable?: | Total Hours: | ||
| Analysis_owners: | pap | Design_owners: | alex |
| Imp._owners: | alex | Test_owners: | |
| Analysis_reviewers: | pav | Changelog: | |
| Design_reviewers: | tanya | Imp._reviewers: | pap |
| Test_reviewers: | Analysis_score: | 3 | |
| Design_score: | 3 | Imp._score: | 3.5 |
| Test_score: | 0 |
Description
wiki page: SCENE_AUDIO_POINT_R0 - effort: 0.5d
Change History
comment:1 Changed 16 years ago by pap
- Owner changed from Astea to pap
- Status changed from new to analyzing
comment:3 Changed 16 years ago by pavlina
- Status changed from analyzed to analysis_accepted
3p by Pav(done:10m)
comment:4 Changed 16 years ago by deyan
- Status changed from analysis_accepted to s1c_analysis_ok
repairing from invalid state
comment:5 Changed 16 years ago by deyan
- Milestone changed from M02_PRE2 to M02b_PRE2b
Milestone change
comment:6 Changed 16 years ago by mira
- Design_owners set to alex
- Status changed from s1c_analysis_ok to s2a_design_started
- Analysis_score set to 0
- Test_score set to 0
- Design_score set to 0
- Owner changed from pap to mira
- Imp._score set to 0
comment:7 Changed 16 years ago by mira
- Status changed from s2a_design_started to s2b_design_finished
comment:9 Changed 16 years ago by Tanya
- Category set to unknown
- Analysis_reviewers set to Pav
- Analysis_score changed from 0 to 3
comment:11 Changed 16 years ago by Tanya
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3
- Design_reviewers set to tanya
The unit test could be better
comment:12 Changed 16 years ago by Tanya
- Owner changed from mira to Tanya
- Status changed from s2c_design_ok to s3a_implementation_started
comment:13 Changed 16 years ago by Tanya
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:14 Changed 16 years ago by pap
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 3.5
- Analysis_owners set to pap
- Imp._reviewers set to pap
Generally it is OK for this revision but there are some things to notice:
- It is not advisable to use fields. You should use properties instead. But what you have done is acceptable for a first revision.
- In the test you have local variables of the interface isntead of the concrete classes(I mean the Handlers). I find that strange.
- The descriptions of the Handler interfaces could be better
comment:17 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.
taken for analyzing along with the other SCENE tasks