Ticket #379 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

APP_COLOR_PICKER_R0

Reported by: Astea Owned by: jani
Priority: 3 Milestone: M04_PRE4
Component: APP_PLUGIN Version: 2.0
Keywords: Cc: jani
Category: MAIN Effort: 0.5
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: danvisel Design_owners: jani
Imp._owners: jani, jani Test_owners:
Analysis_reviewers: deyan Changelog:
Design_reviewers: pap Imp._reviewers: pap,pap
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 3
Test_score: 0

Description

wiki page: APP_COLOR_PICKER_R0 - effort: 0.5d

Change History

comment:1 Changed 13 years ago by dido

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to dido
  • Imp._score set to 0
  • Analysis_owners set to dido

comment:2 Changed 13 years ago by dido

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 13 years ago by deyan

Currently, there is an implementation in the pre-alpha, although some of the functionality there is not working. You can review it and see what can be improved. Probably, HSB and RGB being in one tab is better than the current implementation, but I like more current implementation of privew.

comment:4 Changed 13 years ago by deyan

  • Status changed from s1b_analysis_finished to new

Batch update from file query-1.csv

comment:5 Changed 13 years ago by danvisel

  • Owner changed from dido to danvisel
  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from dido to danvisel

I rewrote this analysis at Jani's request.

comment:6 Changed 13 years ago by danvisel

  • Status changed from s1a_analysis_started to s1b_analysis_finished

time = 4h.

comment:7 Changed 13 years ago by deyan

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to deyan
  • Analysis_score changed from 0 to 4

comment:8 Changed 13 years ago by jani

  • Design_owners set to jani
  • Owner changed from danvisel to jani
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:9 Changed 13 years ago by jani

  • Status changed from s2a_design_started to s2b_design_finished

comment:10 Changed 13 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to pap
  • I like your design.
  • Perhaps you may show the ColorPicker as a panel in the hud.

comment:11 Changed 13 years ago by jani

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to jani

comment:12 Changed 13 years ago by jani

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:13 Changed 13 years ago by pap

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 2
  • Imp._reviewers set to pap
  • Generally the implementation is done in a good manner and looks very good but there are some things that I cannot accept
  • Huds are not supposed to have buttons as done and cancel on them. Sophie relies on direct model manipulation and the cancel should be provided by the undo some day. However this is a minor issue.
  • There are lots of places where you use "new MyControl()" where the later is defined as s VisualElement and is registered to the visual elements extension point. You'd better use autoproperties for these controls that call the computeElementProp method.
  • It this should also apply to the ColorHud and its picker. These properties should have @Own so that the parent-child relalationships are initialized properly.
  • You can use these relationships for easier model manipulation througt the findParentElement method of BaseVisualElement class
  • The color hud should be a kind of an advanced options sub-HUD of some other hud. So perhaps it will be nice to make a boundControl that shows sub-huds.
  • Now it doesn't hide when the BackgoundAndBorderHud is hidden and this produces errors.
  • I know that it is not your responsibilty to synchronize all code changes. But it will be nice if you can sinchronize your solution with the refactorig done that generalized the BoundColorField class
  • The later three things may be considered somehow optional for this revision of the task if you find them too hard to implement.
  • Also it may be nicer if the ColorPicker was a bit smaller as now you can see nothin

comment:14 Changed 13 years ago by pap

  • Cc jani added

adding cc

comment:15 Changed 13 years ago by jani

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners changed from jani to jani, jani

comment:16 Changed 13 years ago by jani

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Most notes taken into account.

comment:17 Changed 13 years ago by pap

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2 to 3
  • Imp._reviewers changed from pap to pap,pap
  • The picker itself is nice but there are some things that were not well done
  • The first is the beforementioned subhud thing.
  • I did this by adding a subHud property of HudDialog an modifying HaloMenu#locationSynk to consider this property.
  • The ColorPicker class still had some strange final properties. These were converted to auto proerties because they know how to compute themselves.
  • There are still some problems with the internal organization of huds and subhuds that need to be improved.

comment:18 Changed 13 years ago by pap

  • Something very important tht is not achieved in this revision is that there should not be a different color picker for each component with adjustable color.

comment:19 Changed 13 years ago by danvisel

I was going to say what Pap did - it's important for users to be able to use the same saved colors in the frame borders that they use in the frame fill. It does seem like the saved fill colors are shared between the page and frames, which is good.

comment:20 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.