APP_LAYOUT_MYDOGGY_R1

[Astea]

wiki page: APP_LAYOUT_MYDOGGY_R1 - effort: 2d

[pap]

• There are some quite unclear parts of the desing(mainly the applet), but let it be
• In SophieDockedContainer class you have a @SuppressWarnings("static-access") - this is not acceptable
• The names fixes of the package is not good.
• I consider this task an improvement but still we need more things to correct there
• Class names MDWindow and MDFrameWindow are not nice - these are main windows. In a moment I thought that MDDocumentWindow is a kind of MDWindow - so the names are mesleading
• Somewhere when talking about DocumentWindows I read the word book. We should get rid of the idea that documents can be only books.
• I have the feeling that the MD engine is still full of bad code so please try to correct at least part of it while implementing.
• Good luck

[peko]

Thanks about the comments.

• I personally do not know about another way of integrating mydoggy and the layout model itself without having a MDAppletWindow. Later it may appear that this is going to be done another way. For the time being this is the only solutions provided and thought of.
• The @SuppressWarnings("static-access") are removed from the SophieDockedContainer, but still this is a design phase and suck things had been thought of for in the implementation phase.
• "fixes" is renamed to "mdcustomization" as discussed, although this is not a customization but a bug fix.
• MDWindow is now renamed to MDMainWindow. Absolutely agree that that way misleading.
• Renamed to opened documents.
• I do not see any bad code there, since there are only two methods there. The actual showing of the MDMainWindow (whether with an applet or a frame) should of course be refactored, but for the time being we have no clear idea about this, so I am going to leave it that way till we discuss this with other people.

[pap]

• I find this task relatively good implemented after some remarks. :)
• Perhaps some ideas my be rethought - about anchoring and MDLayoutElements reusing
• Good luck :)

[pap]

adding cc

[deyan]

Batch update from file query-obsoleted.csv