Ticket #395 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

APP_PLUGIN_STARTUP_R0

Reported by: Astea Owned by: pavlina
Priority: 3 Milestone: M02b_PRE2b
Component: APP_PLUGIN Version: 2.0
Keywords: Cc:
Category: unknown Effort: 0.5
Importance: 50 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: pap Design_owners: pav
Imp._owners: pav, Alex, pav Test_owners:
Analysis_reviewers: peko Changelog:
Design_reviewers: pap,pap Imp._reviewers: pap,pap
Test_reviewers: Analysis_score: 0
Design_score: 3 Imp._score: 4
Test_score: 0

Description

wiki page: APP_PLUGIN_STARTUP_R0 - effort: 0.5d

Change History

comment:1 Changed 14 years ago by todor

  • Owner changed from Astea to todor
  • Status changed from new to analyzing

comment:2 Changed 14 years ago by todor

  • Status changed from analyzing to analyzed

comment:3 Changed 14 years ago by todor

  • Status changed from analyzed to analysis_accepted

comment:4 Changed 14 years ago by pavlina

  • Owner changed from todor to pavlina
  • Status changed from analysis_accepted to designing

comment:5 Changed 14 years ago by pavlina

  • Status changed from designing to designed

comment:6 Changed 14 years ago by pap

  • Status changed from designed to analysis_accepted

Review: 2. The file is log4j.properties. I don't think we need an Activator. This module may just embed felix.

comment:7 Changed 14 years ago by pavlina

  • Status changed from analysis_accepted to designing

comment:8 Changed 14 years ago by pavlina

  • Status changed from designing to designed

comment:9 Changed 14 years ago by pap

  • Status changed from designed to design_accepted

Review: 3. Sufficient

comment:10 Changed 14 years ago by pap

  • Status changed from design_accepted to s2c_design_ok

transfer to new workflow

comment:11 Changed 14 years ago by pavlina

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:12 Changed 14 years ago by deyan

  • Milestone changed from M02_PRE2 to M02b_PRE2b

Milestone change

comment:13 Changed 14 years ago by pavlina

  • Design_owners set to Pavlina
  • Design_score set to 3
  • Imp._score set to 0
  • Test_score set to 0
  • Analysis_score set to 0

comment:14 Changed 14 years ago by pavlina

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Imp._owners set to Pavlina

8h. 4h Pav + 4h Pav,Alex.

comment:15 Changed 14 years ago by pavlina

  • Imp._owners changed from Pavlina to Pavlina, Alex

comment:16 Changed 14 years ago by pap

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 2
  • Imp._reviewers set to Pa
  • You should use a StringBuffer or StringBuilder when constructing strings in loops. Note that String class in Java is immutable and such an use(org.sophie2.launcher.Main line 64) is considered a bad practice as it is slow and produses a lot of unused objects.
  • The file launcher.Main.launch is quite strange to me. I think you didn't get the idea of different launch configurations for different editions well.
  • You should modify TrueAuthorMain in order to execute org.sophie2.launcher.Main in the target/classes subdir of the author module.
  • In the beforementioned directory is the bundles.config file. It gets there automatically from src/main/resources during compilation so it's not necessary to include ../../../src...... in the command-line argument
  • You should modify pom.xml file of the launcehr module. Uncomment the <Main-Class> row and set appropriately. Otherwise the resulting jar file will not be runnable.
  • I suggest that the config file contains only module names (e.g. org.sophie2.core.modularity) without any path prepended or appended. This way we're not bound to the concrete directory structure and can easily introduce a new one.
  • Perhaps logging initialization could've been moved here too as the config file is in the same place and this way other tasks are simplified.
  • You have some unnecessary final keywords in the main method.
  • Although I think you should delete the launcher.Main.launch file I have to mention it loads the server instead of the author

comment:17 Changed 14 years ago by pap

  • Imp._reviewers changed from Pa to Pap

misspelled my id

comment:18 Changed 14 years ago by pavlina

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:19 Changed 14 years ago by pavlina

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:20 Changed 14 years ago by pavlina

  • Imp._owners changed from Pavlina, Alex to Pavlina, Pavlina, Alex
  • Analysis_owners set to pap

comment:21 Changed 14 years ago by pap

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._owners changed from Pavlina, Pavlina, Alex to Pavlina, Alex, Pavlina
  • Imp._score changed from 2 to 4
  • Imp._reviewers changed from Pap to pap,pap

I think now the module is much better and makes the application starting more flexible.

comment:22 Changed 14 years ago by peko

  • Category set to unknown
  • Analysis_reviewers set to peko

comment:23 Changed 14 years ago by pap

  • Design_reviewers set to pap,pap

setting some custom fields

comment:24 Changed 13 years ago by deyan

  • Design_owners changed from Pavlina to pav
  • Imp._owners changed from Pavlina, Alex, Pavlina to pav, Alex, pav

Batch update from file newimport.csv

comment:25 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.