Ticket #538 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

BOOK_BOTTOM_PANEL_R0

Reported by: Astea Owned by: Tanya
Priority: 3 Milestone: M02b_PRE2b
Component: BOOK_VIEW Version: 2.0
Keywords: Cc:
Category: unknown Effort: 0.5
Importance: 20 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: pap,pap Design_owners: peko
Imp._owners: peko, peko, tanya Test_owners: danvisel
Analysis_reviewers: tanya,pav Changelog:
Design_reviewers: pap Imp._reviewers: sriggins, tanya,boyan
Test_reviewers: Analysis_score: 3
Design_score: 3.5 Imp._score: 3
Test_score: 3

Description

wiki page: BOOK_BOTTOM_PANEL_R0 - effort: 0.5d

Change History

comment:1 Changed 14 years ago by todor

  • Owner changed from Astea to todor
  • Status changed from new to analyzing

comment:2 Changed 14 years ago by todor

  • Status changed from analyzing to analyzed

comment:3 Changed 14 years ago by todor

  • Status changed from analyzed to new

comment:4 Changed 14 years ago by todor

  • Status changed from new to analyzing

comment:5 Changed 14 years ago by todor

  • Status changed from analyzing to analyzed

comment:6 Changed 14 years ago by pavlina

  • Status changed from analyzed to analysis_accepted

comment:7 Changed 14 years ago by peko

  • Owner changed from todor to peko
  • Status changed from analysis_accepted to designing

comment:8 Changed 14 years ago by peko

  • Status changed from designing to designed

comment:9 Changed 14 years ago by pap

  • Status changed from designed to design_accepted

3.5 by Pap. The design is good enough.

comment:10 Changed 14 years ago by peko

  • Status changed from design_accepted to implementing

comment:11 Changed 14 years ago by peko

  • Status changed from implementing to implemented

comment:12 Changed 14 years ago by milo

  • Status changed from implemented to s3b_implementation_finished

comment:13 Changed 14 years ago by Tanya

  • Status changed from s3b_implementation_finished to s2c_design_ok

2
It is good but there are some things that could be better done. Extensions should not be added in the constructor, resource property is a better idea. What is more, some unit test could be added because tests are not enough.

comment:14 Changed 14 years ago by peko

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:15 Changed 14 years ago by peko

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:16 Changed 14 years ago by deyan

  • Milestone changed from M02_PRE2 to M02b_PRE2b

Milestone change

comment:17 Changed 14 years ago by sriggins

  • Design_score set to 0
  • Imp._reviewers set to sriggins
  • Imp._score set to 0
  • Test_score set to 0
  • Analysis_score set to 0

comment:18 Changed 14 years ago by sriggins

It appears as if the extension point is now created outside of the constructor, but I am too new to Java to be certain.
"extentionPoint" is misspelled (should be extensionPoint)
I cannot test this due to a runtime error (http://groups.google.com/group/sophie2-devs/browse_thread/thread/580b5c4c9520e2fa#)
I don't see any unit tests, but I am probably not looking in the right location.

comment:19 Changed 14 years ago by peko

  • Design_owners set to peko
  • Imp._owners set to peko

comment:20 Changed 14 years ago by sriggins

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5

Other than the spelling error, this appears fine. It took me some time to review because I did not know where the extensions were defined, and thus how any of this code worked. Once it was explained, I understand better.

It should be noted that each panel extension is a subclass of the panel superclass. Adding more modules to the book panel would require a new subclass to be written and the extension registered in org.sophie2.messy/messy/MessyModule.java, getExtensions()

comment:21 Changed 14 years ago by Tanya

  • Analysis_owners set to Tanya

comment:22 Changed 14 years ago by Tanya

  • Status changed from s3c_implementation_ok to s2c_design_ok
  • Imp._score changed from 3.5 to 2
  • Imp._reviewers changed from sriggins to sriggins, Tanya

It's not OK. Resource property should be created for extensions.

comment:23 Changed 14 years ago by Tanya

  • Analysis_owners changed from Tanya to tanya
  • Imp._reviewers changed from sriggins, Tanya to sriggins, tanya

comment:24 Changed 14 years ago by Tanya

  • Owner changed from peko to Tanya
  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners changed from peko to peko, tanya

comment:25 Changed 14 years ago by Tanya

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:26 Changed 14 years ago by boyan

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2 to 3
  • Imp._reviewers changed from sriggins, tanya to sriggins, tanya,boyan

ok (20m)

comment:27 Changed 14 years ago by peko

  • Category set to unknown
  • Imp._owners changed from peko, tanya to peko, peko, tanya

comment:28 Changed 14 years ago by pap

  • Design_score changed from 0 to 3.5
  • Design_reviewers set to pap
  • Analysis_reviewers set to tanya,pav
  • Analysis_owners changed from tanya to pap,pap
  • Analysis_score changed from 0 to 3

filling custom fields

comment:29 Changed 14 years ago by danvisel

  • Status changed from s3c_implementation_ok to s4a_test_started

comment:30 Changed 14 years ago by danvisel

  • Test_owners set to danvisel
  • Test_score changed from 0 to 3

test created & run, works.

comment:31 Changed 13 years ago by danvisel

  • Status changed from s4a_test_started to s4b_test_finished

comment:32 Changed 13 years ago by deyan

  • Status changed from s4b_test_finished to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.