Ticket #541 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

PREVIEW_MODE_R0

Reported by: Astea Owned by: kyli
Priority: 3 Milestone: M04_PRE4
Component: BOOK_VIEW Version: 2.0
Keywords: Cc:
Category: MAIN Effort: 1
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: mitex, kyli, dido Design_owners: peko, kyli
Imp._owners: kyli Test_owners:
Analysis_reviewers: kyli,deyan,deyan Changelog:
Design_reviewers: boyan, meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 4
Test_score: 0

Description

wiki page: PREVIEW_MODE_R0 - effort: 1d

Change History

comment:1 Changed 13 years ago by mitex

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to mitex
  • Imp._score set to 0
  • Analysis_owners set to mitex

taken for analysis

comment:2 Changed 13 years ago by mitex

  • Design_score set to 0
  • Test_score set to 0
  • Imp._score set to 0
  • Analysis_owners set to mitex
  • Analysis_score set to 0

Analysis_owners field was deleted by unknown reason so I filled it again.

comment:3 Changed 13 years ago by mitex

  • Status changed from s1a_analysis_started to s1b_analysis_finished

finished analysis

comment:4 Changed 13 years ago by kyli

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to kyli
  • Analysis_score changed from 0 to 3

3p. I believe that halo menus should also be hidden in reader/preview mode. Also, I don't get the second implementation idea.

comment:5 Changed 13 years ago by peko

  • Ticket_group set to GROUP_LINKS_R0

comment:6 Changed 13 years ago by peko

  • Design_owners set to peko
  • Owner changed from mitex to peko
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:7 Changed 13 years ago by peko

  • Status changed from s2a_design_started to s2b_design_finished

comment:8 Changed 13 years ago by boyan

  • Ticket_group GROUP_LINKS_R0 deleted

ungrouping task

comment:9 Changed 13 years ago by boyan

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2
  • Design_reviewers set to boyan

The design is vague at some places:

  • You should state where (in which classes/packages) the menu and menu items will be added - this is a design issue.
  • "Some menu items" is too vague for a design - you should state which items exactly will be disabled. Should the whole Edit menu be disabled? What about undo/redo of adding and editing stickies and other annotations?

And some minor notes:

  • The tooltip of the view menu is better be "View menu" (for consistency with other menus and because at a later stage it will not contain only view modes).
  • The tooltip of the preview mode item is better to be "Switch to preview mode for the current book" (it is shorter and consistent with other tooltips).

comment:10 Changed 13 years ago by peko

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:11 Changed 13 years ago by peko

  • Status changed from s2a_design_started to s2b_design_finished

comment:12 Changed 13 years ago by pap

  • Status changed from s2b_design_finished to new

Super reviewed
The task is too outdated

  • The analysis should be discussed again with milo and the integration team.
  • The behavior of the preview mode should be made compatible with full screen modes and the reader task(if already implemented).
  • This is a high-priority task

comment:13 Changed 13 years ago by kyli

  • Owner changed from peko to kyli
  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from mitex to mitex, kyli

Starting..

comment:14 Changed 13 years ago by dido

  • Analysis_owners changed from mitex, kyli to mitex, kyli, dido

comment:15 Changed 13 years ago by dido

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:16 Changed 13 years ago by deyan

  • Status changed from s1b_analysis_finished to new
  • Analysis_reviewers changed from kyli to kyli,deyan
  • Analysis_score changed from 3 to 2

Frame borders will be visible if they are set so, the page borders will be visible also (all of them).
Can you explain that further? Will you be able to outline frames? Maybe it's a good feature in author application, but you decide.
The task requirements are unclear - what will be working in this prototype? Please, provide more exact requiremets.

comment:17 Changed 13 years ago by kyli

  • Status changed from new to s1a_analysis_started

ok, starting again..

comment:18 Changed 13 years ago by kyli

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:19 Changed 13 years ago by deyan

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers changed from kyli,deyan to kyli,deyan,deyan
  • Analysis_score changed from 2 to 3.5

enough for r0

comment:20 Changed 13 years ago by kyli

  • Status changed from s1c_analysis_ok to s2a_design_started

starting design..

comment:21 Changed 13 years ago by kyli

  • Design_owners changed from peko to peko, kyli

comment:22 Changed 13 years ago by kyli

  • Status changed from s2a_design_started to s2b_design_finished

done.

comment:23 Changed 13 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2 to 3.5
  • Design_reviewers changed from boyan to boyan, meddle

For that task, and having in mind that is mainly user point of view related, I think the design is OK.

3.5p (1h)

comment:24 Changed 13 years ago by kyli

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to kyli

comment:25 Changed 13 years ago by kyli

  • Status changed from s3a_implementation_started to s3b_implementation_finished

The implementation was ready several days ago, just passing to "finished" now.

comment:26 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle

The implementation is according to the design and the tests work. I like the code quality and there are no bugs for now, so 4p (45m)

comment:27 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.