Ticket #544 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

BOOK_FULL_SCREEN_MODE_R0

Reported by: Astea Owned by: tanya
Priority: 3 Milestone: M04_PRE4
Component: BOOK_VIEW Version: 2.0
Keywords: full screen, presentation mode Cc: mitex, tanya
Category: MAIN Effort: 1
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: dido Design_owners: tanya, mitex
Imp._owners: tanya, mitex Test_owners:
Analysis_reviewers: kyli, meddle Changelog:
Design_reviewers: pap Imp._reviewers: meddle,pap
Test_reviewers: Analysis_score: 4
Design_score: 3.5 Imp._score: 3
Test_score: 0

Description

wiki page: BOOK_FULL_SCREEN_MODE_R0 - effort: 1d

Change History

comment:1 Changed 14 years ago by mitex

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to mitex
  • Imp._score set to 0
  • Analysis_owners set to mitex

taken for analysis

comment:2 Changed 14 years ago by mitex

  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Imp._score set to 0
  • Analysis_owners set to mitex

comment:3 Changed 14 years ago by kyli

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to kyli
  • Analysis_score changed from 0 to 4

4p. Seems OK to me.

comment:4 Changed 14 years ago by mitex

  • Design_owners set to tanya, mitex
  • Imp._owners set to tanya, mitex

comment:5 Changed 14 years ago by dido

  • Status changed from s1c_analysis_ok to new

comment:6 Changed 14 years ago by dido

  • Owner changed from mitex to dido
  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from mitex to dido

comment:7 Changed 14 years ago by dido

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:8 Changed 14 years ago by meddle

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers changed from kyli to kyli, meddle

It's simple and clear. 4p (15m)

comment:9 Changed 14 years ago by mitex

  • Owner changed from dido to mitex
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:10 Changed 14 years ago by mitex

  • Status changed from s2a_design_started to s2b_design_finished

comment:11 Changed 14 years ago by dido

  • Things that are not implemented in this revision should go to next one.

comment:12 Changed 14 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to pap
  • The design looks acceptable.
  • Be sure to use appropriate assert* methods in tests

comment:13 Changed 14 years ago by mitex

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:14 Changed 14 years ago by mitex

  • Keywords full screen, presentation mode added
  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:15 Changed 14 years ago by kyli

Here is something like a feedback from me when I looked through the screen modes in the latest release - Alpha 1:

  • I tried to press F11 six times (This means to open and close Full screen mode 3 times) and the bottom flap become so huge, that the book got hidden.
  • I restarted Sophie2 Alpha 1, pressed F5 and went to presentation mode. The top border you argued with Milo about was still there - it's a bit annoying.. But after that I couldn't find a way to go to normal mode again (in presentation mode, F5 does not seem to work and the menu is hiden), except the button "Close preview". But when I clicked it, the original book was closed (It seems that after I told you to call the BookLogic methods, you still just set a property and do nothing - this way, after the end of the presentation may be completely differrent which is unacceptable). The only way to exit presentation mode I found, was to exit Sophie2 Alpa 1. I got interested and checked out your branch in order to see what causes this strange behaviour.
  • I started sophie2 with the Fake launch configuration and started presentation mode. There I could exit to normal mode by pressing Esc - obviously, it was my mistake that I couldn't exit before. However, it seems a bit strange to exit full screen with F11 and exit presentation with Esc.. I tried several more times - You do really have a problem with the Esc :) maybe some kind of focus lost, I don't know..
  • Then I decided to take a look at the code - the first (and last) thing I looked at were the 2 menu items for the fullscreen and presentation modes (I am a bit interested in them, since I have to use the same menu for my task). I noticed that you fire R3 events, but you do not seem to handle them anywhere - the logic is put right below the evenr firing.. This is very strange :) The other thing I noticed was that you have totally 4 TODO's in these 2 classes. Maybe thay are better to be mentioned in the "not implemented" section? The things I concluded were that :
  • You have not taken point of Milo's advise to fix the page borders, neither you have discussed the keyboard shortcuts for theese modes.
  • You do not get interested in other's code even in you use it - for example, the preview mode.
  • You do not wish to ask how to implement EventR3 handling. Actually, I would be glad to help you for this, if you had asked..
  • The tests you have written are actually 2 test cases, added in a demo, which currently throws exceptions - I don't know why the design has passed.. The feedback took me about 1h30m, but I won't write this down to my report, since I just wanted to see Sophie2 Aplha1 from the user's point of view.

comment:16 Changed 14 years ago by meddle

  • Cc mitex, tanya added
  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 2
  • Imp._reviewers set to meddle

I'll fail this implementation. Please see the comments from kyli above and this notes:

  • The code is in bad quality.
  • Your branch is in terrible condition, the fullscreen is practically hard to merge and when merged there could be missed things and errors.
  • The user point of view is important thing!
  • For that revision you could implement the fullscreen only and the presentation mode you can leave for the next revision.
  • I made a branch for the fullscreen at svn://sophie2.org/sophie2/branches/fullscreen. It is a temporary branch for the fullscreen.

comment:17 Changed 14 years ago by tanya

  • Owner changed from mitex to tanya
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:18 Changed 14 years ago by tanya

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:19 Changed 14 years ago by pap

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2 to 3
  • Imp._reviewers changed from meddle to meddle,pap

I'll pass this but there are several things that should be considered.

  • The name IDs is not nice. EventIds is more informational.(Renamed)
  • Having the "Normal mode" item is a bit strange. In the next revision this should be discussed with the analysis people, but I find it unnecessary.
  • The way you get the main window in "FullScreenLogic" may be better. It should rather use the findParent method and be more property safe(check for nulls and uninitialized properties).
  • In MDDocumentWindow's swingFrame you have some strange remove/add listeners. Also you'd better use BaseVisualElement's findParentElement method rather than those long parent().get()... which you do unsafely.
  • The Application level UI hierarchy has become too complex to and its implementation too bloated, but this is not in the scope of this task.

comment:20 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.