BOOK_FULL_SCREEN_MODE_R0

[Astea]

wiki page: BOOK_FULL_SCREEN_MODE_R0 - effort: 1d

[mitex]

taken for analysis

[kyli]

4p. Seems OK to me.

[meddle]

It's simple and clear. 4p (15m)

[dido]

• Things that are not implemented in this revision should go to next one.

[pap]

• The design looks acceptable.
• Be sure to use appropriate assert* methods in tests

[kyli]

Here is something like a feedback from me when I looked through the screen modes in the latest release - Alpha 1:

• I tried to press F11 six times (This means to open and close Full screen mode 3 times) and the bottom flap become so huge, that the book got hidden.
• I restarted Sophie2 Alpha 1, pressed F5 and went to presentation mode. The top border you argued with Milo about was still there - it's a bit annoying.. But after that I couldn't find a way to go to normal mode again (in presentation mode, F5 does not seem to work and the menu is hiden), except the button "Close preview". But when I clicked it, the original book was closed (It seems that after I told you to call the BookLogic methods, you still just set a property and do nothing - this way, after the end of the presentation may be completely differrent which is unacceptable). The only way to exit presentation mode I found, was to exit Sophie2 Alpa 1. I got interested and checked out your branch in order to see what causes this strange behaviour.
• I started sophie2 with the Fake launch configuration and started presentation mode. There I could exit to normal mode by pressing Esc - obviously, it was my mistake that I couldn't exit before. However, it seems a bit strange to exit full screen with F11 and exit presentation with Esc.. I tried several more times - You do really have a problem with the Esc :) maybe some kind of focus lost, I don't know..
• Then I decided to take a look at the code - the first (and last) thing I looked at were the 2 menu items for the fullscreen and presentation modes (I am a bit interested in them, since I have to use the same menu for my task). I noticed that you fire R3 events, but you do not seem to handle them anywhere - the logic is put right below the evenr firing.. This is very strange :) The other thing I noticed was that you have totally 4 TODO's in these 2 classes. Maybe thay are better to be mentioned in the "not implemented" section? The things I concluded were that :
• You have not taken point of Milo's advise to fix the page borders, neither you have discussed the keyboard shortcuts for theese modes.
• You do not get interested in other's code even in you use it - for example, the preview mode.
• You do not wish to ask how to implement EventR3 handling. Actually, I would be glad to help you for this, if you had asked..
• The tests you have written are actually 2 test cases, added in a demo, which currently throws exceptions - I don't know why the design has passed.. The feedback took me about 1h30m, but I won't write this down to my report, since I just wanted to see Sophie2 Aplha1 from the user's point of view.

[meddle]

I'll fail this implementation. Please see the comments from kyli above and this notes:

• The code is in bad quality.
• Your branch is in terrible condition, the fullscreen is practically hard to merge and when merged there could be missed things and errors.
• The user point of view is important thing!
• For that revision you could implement the fullscreen only and the presentation mode you can leave for the next revision.
• I made a branch for the fullscreen at ​svn://sophie2.org/sophie2/branches/fullscreen. It is a temporary branch for the fullscreen.

[pap]

I'll pass this but there are several things that should be considered.

• The name IDs is not nice. EventIds is more informational.(Renamed)
• Having the "Normal mode" item is a bit strange. In the next revision this should be discussed with the analysis people, but I find it unnecessary.
• The way you get the main window in "FullScreenLogic" may be better. It should rather use the findParent method and be more property safe(check for nulls and uninitialized properties).
• In MDDocumentWindow's swingFrame you have some strange remove/add listeners. Also you'd better use BaseVisualElement's findParentElement method rather than those long parent().get()... which you do unsafely.
• The Application level UI hierarchy has become too complex to and its implementation too bloated, but this is not in the scope of this task.

[deyan]

Batch update from file query-obsoleted.csv