BOOK_PROPERTIES_DIALOG_R0

[Astea]

wiki page: BOOK_PROPERTIES_DIALOG_R0 - effort: 0.5d

[mitex]

taken for analysis

[mitex]

analysis finished

[deyan]

adding analysis owners

[deyan]

Batch update from file query-1.csv

[diana]

started analysis

[dido]

• Add the entire meta data of the book to this dialog(author, comments etc.). This should be part of the overview of the task.
• Extend implementation section of the wiki page if needed.
• In design idea please provide more information.
• It will be great if we could dynamically read the meta data of the book and display it. Not to hard code some fields that should change if the model is changed.
• Also please review the meta data display in resource panel (APP_RESOURCE_PROPERTIES_DISPLAY_R0, GROUP_APP_RESOURCE_R0) And make sure the display is consistent. Make sure that the editable fields are indicated somehow for the user.

[deyan]

since the dialog is modal, "It will be great if we could dynamically read the meta data of the book and display it. Not to hard code some fields that should change if the model is changed." doesn;t make sense

[diana]

starting design

[diana]

finished design

[meddle]

Super review:

The main idea of this task is to have something like modal dialog with OK/Cancel buttons and three fields : title, height and width when creating the book. This dialog don't know about the book and takes a bean like BookInfo, and if the user presses cancel the book is not created at all... reanalysis and redesign is needed, low priority....

(130m) :(((

[dido]

The SetBookTitleItem and SetPageSizeItem buttons in the edit menu should be removed. Think that this is also a part of this task so if you have time please do this. (Please confirm this with Milo first)
Analysis_review 3.5p (15m)

[meddle]

See :
SetBookTitleItem and SetPageSizeItem buttons in the edit menu should be removed. Think that this is also a part of this task so if you have time please do this. (Please confirm this with Milo first) -- dido
For the implementation you must discuss with Milo!

• Your test works for your purposes.
  • The spacing is bad. (assertEquals(i.getBookTitle(),book.title().get()); -> assertEquals(i.getBookTitle(), book.title().get());)
  • The name "i" for the test BookInfo is bad, we have no special rules for naming, but only one letter is ugly.
  • "This class should test the"; Should??
• Svn problems : read about merging and revisions, that revision is not mergeble into the trunk
• When some class will be immutable write it in the design!

3p (35m)

[boyan]

removing cc

[meddle]

bookPropertiesCancelException.txt

[meddle]

• Problems with the code:
  • You have fake JavaDoc, next time I see such thing I'll fail the implementation!
  • You have "@SuppressWarnings("static-access")", that is forbidden see GoodCodeExamples. It's not my work to fix your mistakes...
  • Some strings that you use in your code like the " OK ", should be extracted to constants.
  • What is this style for the curly brackets???

    						if(width < Page.MIN_PAGE_WIDTH || width > Page.MAX_PAGE_WIDTH)
    						{
    							SwingDialog.this.verificationLabel.setText("Not correct width!");
    							return;
    						}
    

  • Your spacing is alfull.
• Problems with your branch maintanencew:
  • Your branch is hardly merge-able, so the next time you want implementation review you will create a new branch and write your code there. Clean.
• Bugs :
  • When I create a book with your dialog the book's pages width and height are switched, see the constructor of your BookInfo class and fix it.
  • When Cancel is clicked there is an exception thrown see the atachment "bookPropertiesCancelException.txt" (That is applied only to the case when the fake application starts and the firs authomatic book wants to be created.)
  • The greatest problem is that the dialog is not active the first time the application starts and becomes active when we minimize-maximize the application.

[deyan]

Batch update from file query-obsoleted.csv