Ticket #615 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

BOOK_PROPERTIES_DIALOG_R0

Reported by: Astea Owned by: diana
Priority: 3 Milestone: M04_PRE4
Component: BOOK_MANAGING Version: 2.0
Keywords: Cc: diana
Category: MAIN Effort: 0.5
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: mitex,diana Design_owners: diana
Imp._owners: Test_owners:
Analysis_reviewers: dido Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3 Imp._score: 3
Test_score: 0

Description

wiki page: BOOK_PROPERTIES_DIALOG_R0 - effort: 0.5d

Attachments

bookPropertiesCancelException.txt (819.4 KB) - added by meddle 13 years ago.
bookPropertiesCancelException.txt

Change History

comment:1 Changed 13 years ago by mitex

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to mitex
  • Imp._score set to 0
  • Analysis_owners set to mitex

taken for analysis

comment:2 Changed 13 years ago by mitex

  • Status changed from s1a_analysis_started to s1b_analysis_finished

analysis finished

comment:3 Changed 13 years ago by deyan

  • Design_score set to 0
  • Test_score set to 0
  • Imp._score set to 0
  • Analysis_owners set to mitex
  • Analysis_score set to 0

adding analysis owners

comment:4 Changed 13 years ago by deyan

  • Status changed from s1b_analysis_finished to new

Batch update from file query-1.csv

comment:5 Changed 13 years ago by diana

  • Owner changed from mitex to diana
  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from mitex to mitex,diana

started analysis

comment:6 Changed 13 years ago by diana

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:7 Changed 13 years ago by dido

  • Analysis_reviewers set to dido
  • Analysis_score changed from 0 to 2.5
  • Add the entire meta data of the book to this dialog(author, comments etc.). This should be part of the overview of the task.
  • Extend implementation section of the wiki page if needed.
  • In design idea please provide more information.
  • It will be great if we could dynamically read the meta data of the book and display it. Not to hard code some fields that should change if the model is changed.
  • Also please review the meta data display in resource panel (APP_RESOURCE_PROPERTIES_DISPLAY_R0, GROUP_APP_RESOURCE_R0) And make sure the display is consistent. Make sure that the editable fields are indicated somehow for the user.

comment:8 Changed 13 years ago by dido

  • Status changed from s1b_analysis_finished to new

comment:9 Changed 13 years ago by deyan

since the dialog is modal, "It will be great if we could dynamically read the meta data of the book and display it. Not to hard code some fields that should change if the model is changed." doesn;t make sense

comment:10 Changed 13 years ago by diana

  • Status changed from new to s1a_analysis_started

comment:11 Changed 13 years ago by diana

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:12 Changed 13 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 2.5 to 3

comment:13 Changed 13 years ago by diana

  • Design_owners set to diana
  • Status changed from s1c_analysis_ok to s2a_design_started

starting design

comment:14 Changed 13 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

finished design

comment:15 Changed 13 years ago by meddle

  • Status changed from s2b_design_finished to new

Super review:

The main idea of this task is to have something like modal dialog with OK/Cancel buttons and three fields : title, height and width when creating the book. This dialog don't know about the book and takes a bean like BookInfo, and if the user presses cancel the book is not created at all... reanalysis and redesign is needed, low priority....

(130m) :(((

comment:16 Changed 13 years ago by diana

  • Status changed from new to s1a_analysis_started

comment:17 Changed 13 years ago by diana

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:18 Changed 13 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 3 to 3.5

The SetBookTitleItem and SetPageSizeItem buttons in the edit menu should be removed. Think that this is also a part of this task so if you have time please do this. (Please confirm this with Milo first)
Analysis_review 3.5p (15m)

comment:19 Changed 13 years ago by diana

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:20 Changed 13 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

comment:21 Changed 13 years ago by meddle

  • Cc diana, boyan added
  • Design_score changed from 0 to 3
  • Design_reviewers set to meddle
  • Status changed from s2b_design_finished to s2c_design_ok

See :
SetBookTitleItem and SetPageSizeItem buttons in the edit menu should be removed. Think that this is also a part of this task so if you have time please do this. (Please confirm this with Milo first) -- dido
For the implementation you must discuss with Milo!

  • Your test works for your purposes.
    • The spacing is bad. (assertEquals(i.getBookTitle(),book.title().get()); -> assertEquals(i.getBookTitle(), book.title().get());)
    • The name "i" for the test BookInfo is bad, we have no special rules for naming, but only one letter is ugly.
    • "This class should test the"; Should??
  • Svn problems : read about merging and revisions, that revision is not mergeble into the trunk
  • When some class will be immutable write it in the design!


3p (35m)

comment:22 Changed 13 years ago by boyan

  • Cc boyan removed

removing cc

comment:23 Changed 13 years ago by diana

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:24 Changed 13 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Changed 13 years ago by meddle

bookPropertiesCancelException.txt

comment:25 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to meddle
  • Problems with the code:
    • You have fake JavaDoc, next time I see such thing I'll fail the implementation!
    • You have "@SuppressWarnings("static-access")", that is forbidden see GoodCodeExamples. It's not my work to fix your mistakes...
    • Some strings that you use in your code like the " OK ", should be extracted to constants.
    • What is this style for the curly brackets???
      						if(width < Page.MIN_PAGE_WIDTH || width > Page.MAX_PAGE_WIDTH)
      						{
      							SwingDialog.this.verificationLabel.setText("Not correct width!");
      							return;
      						}
      
    • Your spacing is alfull.
  • Problems with your branch maintanencew:
    • Your branch is hardly merge-able, so the next time you want implementation review you will create a new branch and write your code there. Clean.
  • Bugs :
    • When I create a book with your dialog the book's pages width and height are switched, see the constructor of your BookInfo class and fix it.
    • When Cancel is clicked there is an exception thrown see the atachment "bookPropertiesCancelException.txt" (That is applied only to the case when the fake application starts and the firs authomatic book wants to be created.)
    • The greatest problem is that the dialog is not active the first time the application starts and becomes active when we minimize-maximize the application.


comment:26 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.