Ticket #669 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

PAGE_ELEMENT_GROUPING_R0

Reported by: Astea Owned by: kyli
Priority: 3 Milestone: M06_ALPHA1
Component: PAGE_ELEMENTS Version: 2.0
Keywords: Cc:
Category: EXTRA Effort: 0.5
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: peko, kyli, dido Design_owners: kyli
Imp._owners: kyli Test_owners:
Analysis_reviewers: -deyan,deyan,deyan Changelog:
Design_reviewers: kyli,pap Imp._reviewers: meddle, pap
Test_reviewers: Analysis_score: 3.5
Design_score: 3 Imp._score: 3
Test_score: 0

Description

wiki page: PAGE_ELEMENT_GROUPING_R0 - effort: 0.5d

Change History

comment:1 Changed 14 years ago by peko

  • Design_score set to 0
  • Ticket_group set to GROUP_PAGE_ELEMENTS_GROUP_ALIGN
  • Imp._score set to 0
  • Test_score set to 0
  • Analysis_score set to 0

comment:2 Changed 14 years ago by peko

  • Ticket_group GROUP_PAGE_ELEMENTS_GROUP_ALIGN deleted

comment:3 Changed 14 years ago by peko

  • Ticket_group set to GROUP_PAGE_ELEMENTS_GROUP_ALIGN_R0

comment:4 Changed 14 years ago by peko

  • Owner changed from Astea to peko
  • Status changed from new to s1a_analysis_started
  • Analysis_owners set to peko

comment:5 Changed 14 years ago by peko

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:6 Changed 14 years ago by deyan

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to deyan
  • Analysis_score changed from 0 to 3

For first revision the analysis is enough, but some things are missing - for example the z-order behavior and representation in the resources palette. Seems a little incomplete.

comment:7 Changed 14 years ago by deyan

  • Cc deyan added

Batch update from file newimport.csv

comment:8 Changed 14 years ago by deyan

  • Ticket_group GROUP_PAGE_ELEMENTS_GROUP_ALIGN_R0 deleted

The group is invalid, not deleting the custom field preserves the ticket from showing on the iteration page. Be careful.

comment:9 Changed 14 years ago by deyan

  • Cc deyan removed

comment:10 Changed 14 years ago by deyan

  • Status changed from s1c_analysis_ok to new
  • Analysis_reviewers changed from deyan to -deyan,deyan
  • Analysis_score changed from 3 to 2

Please add movement behavior for example, how a group will be rotated, etc. Which halos will be present for a group? what is the behavior of each control (specific, for example setting a border)

comment:11 Changed 14 years ago by kyli

  • Owner changed from peko to kyli
  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from peko to peko, kyli

Starting!

comment:12 Changed 14 years ago by dido

  • Analysis_owners changed from peko, kyli to peko, kyli, dido

comment:13 Changed 14 years ago by dido

analysis 1h

comment:14 Changed 14 years ago by kyli

  • Status changed from s1a_analysis_started to s1b_analysis_finished

Analysis is finished with the help of dido. Group behavior is still not added in the analysis, because after some discussions we decided, that for now it may be the same as multi-selection behavior, which is to be done in PAGE_ELEMENT_MULTI_MANIPULATION_R0.

comment:15 Changed 14 years ago by deyan

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers changed from -deyan,deyan to -deyan,deyan,deyan
  • Analysis_score changed from 2 to 3.5

comment:16 Changed 14 years ago by kyli

  • Design_owners set to kyli
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:17 Changed 14 years ago by kyli

  • Status changed from s2a_design_started to s2b_design_finished

done.

comment:18 Changed 14 years ago by kyli

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2
  • Design_reviewers set to kyli

This design appeared to be weak. Some of the problems are:

  • Renaming PageElement causes too much refactoring and is practically pointless. It is just another name for the same thing.
  • Forcing PageElements in the groups to be also resources is bad - so a list of ResourceRefs is not enough for a container.
  • createGroup should not be static - this way ot needs to be aware in the currentGroup, which is impossible.
  • The currentGroup property should be reconsidered.

comment:19 Changed 14 years ago by kyli

  • Status changed from s1c_analysis_ok to s2a_design_started

Starting design again..

comment:20 Changed 14 years ago by kyli

  • Status changed from s2a_design_started to s2b_design_finished
  • PageElement will not be renamed.
  • An abstract class for PageElement Resources is included in the new design.
  • Only deleteGroup will be static now.
  • Some other minor things were fixed.

comment:21 Changed 14 years ago by pap

  • Cc kyli added
  • Design_score changed from 2 to 3
  • Design_reviewers changed from kyli to kyli,pap
  • Status changed from s2b_design_finished to s2c_design_ok
  • Generally ok but I'm not sure how stable this design will stay.
  • You do not mention the user interaction well enough.
  • I find the test almost useless. Please next time make sure you write higher quality unit tests when you design.
  • Still I find this acceptable for a prototype, especially if it becomes peristable.

comment:22 Changed 14 years ago by kyli

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to kyli

comment:23 Changed 13 years ago by kyli

  • Status changed from s3a_implementation_started to s3b_implementation_finished

done?

comment:24 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to meddle, pap

The implementation works;

  • Code review notes:
    • When you want to create/get ResourceRef to resource that you have and you have it's parent too, use Resource#getChildRef(Resource) method : this.page.addFrame(this.page.getChildRef(this.frame));
    • When you completely change a class remove the old authors names, and put only yours, for example the GroupTest.
    • Write AssertEquals(number, expression), no AssertTrue(number == expression).
    • The second parameter of the ResourceRef#get(Class<? extends Resource>, ProObject) is important when you know the locating object...
    • I think such a way to decide if to show a FrameView Halo is ugly : (pwa.selectedElementViews().get().size() == 1 && pwa.selectedElementViews().get(0) instanceof FrameView) We will have to think of a better way to do it... May be there will be "selectedFrameView" with will be null or something... The same applies for GroupViews and their halos.
    • Bad spacing, random spacing...
  • Bugs:
    • When you have two frames in a group, you enter the group and delete one of them, the group stays and it's visible in the AllResourcePalette.

There are problems deleting some of the resources that's why this bug is acceptable in my view...

3p (4h)

comment:25 Changed 13 years ago by kyli

  • Cc kyli removed

comment:26 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.