Ticket #681 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

PAGE_BORDER_R0

Reported by: Astea Owned by: deni
Priority: 3 Milestone: M05_PRE5
Component: PAGE_PROPERTIES Version: 2.0
Keywords: Cc: deni
Category: MAIN Effort: 0.5
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: deni Design_owners: deni
Imp._owners: deni Test_owners:
Analysis_reviewers: meddle, todor Changelog:
Design_reviewers: pap,pap Imp._reviewers: meddle, meddle
Test_reviewers: Analysis_score: 3
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description

wiki page: PAGE_BORDER_R0? - effort: 0.5d

Change History

comment:1 Changed 13 years ago by sriggins

  • Owner changed from Astea to sriggins
  • Design_score set to 0
  • Imp._score set to 0
  • Test_score set to 0
  • Analysis_score set to 0

comment:2 Changed 13 years ago by sriggins

  • Status changed from new to s1a_analysis_started
  • Analysis_owners set to sriggins

comment:3 Changed 13 years ago by sriggins

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 13 years ago by pav

  • Ticket_group set to GROUP_PAGE_PROPERTIES_R0

comment:5 Changed 13 years ago by deyan

  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 3

Batch update from file import.csv

comment:6 Changed 13 years ago by deyan

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

Batch update from file newimport.csv

comment:7 Changed 13 years ago by todor

  • Status changed from s1c_analysis_ok to new
  • Analysis_reviewers changed from meddle to meddle, todor
  • Analysis_score changed from 3 to 0

too old

comment:8 Changed 13 years ago by deni

  • Owner changed from sriggins to deni
  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from sriggins to deni

comment:9 Changed 13 years ago by deni

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:10 Changed 13 years ago by deyan

  • Ticket_group GROUP_PAGE_PROPERTIES_R0 deleted

comment:11 Changed 13 years ago by deyan

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 0 to 3

Note that padding and margins should be calculated (what will be positive and negative), PAGE_SETS

comment:12 Changed 13 years ago by deni

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:13 Changed 13 years ago by deni

  • Design_owners set to deni
  • Status changed from s2a_design_started to s2b_design_finished

comment:14 Changed 13 years ago by pap

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2
  • Design_reviewers set to pap
  • What you have done is good but it is not of much value with perspective in mind.
  • In order to make the task well it would be good to refactor the BoundMode enumeration.
  • Add some methods(get/set size/position/rect) to it that transform from one bound mode to another and do not have the starting mode fixed.
  • You may preserve the old methods in order not to refactor all uses now. They will just forward the execution to the new methods.
  • Be sure to take the margins in mind, too. That is when making tha page border itself.

comment:15 Changed 13 years ago by pap

  • Cc deni added

adding cc

comment:16 Changed 13 years ago by deni

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:17 Changed 13 years ago by deni

  • Status changed from s2a_design_started to s2b_design_finished

comment:18 Changed 13 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2 to 3.5
  • Design_reviewers changed from pap to pap,pap

I like the design although it didn't take all of the previous review remarks. Also there are some things that are not stated clear enough.

  • The sentence "Therefore the shape() property of the scene should be set to the inner border rectangle." is incorrect. There is no such property in the scene, but I believe you will make the correct implementation.
  • I suggest that you make the page instets non-zero so that you better illustratate that such things exist.

comment:19 Changed 13 years ago by deni

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:20 Changed 13 years ago by deni

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:21 Changed 13 years ago by deni

  • Imp._owners set to deni

comment:22 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 2.5
  • Imp._reviewers set to meddle

The implementation can not pass at this rate, because:

  • The halos are not relocated on the right place and that is a visible bug.
  • And the suggestion that Pap wrote is important thing in my view, make the insets more than zero!
  • Other thing use variables instead of writing expressions on several lines or long expressions, try writing expressions no longer than 80 symbols.

2.5p (25m)

comment:23 Changed 13 years ago by deni

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:24 Changed 13 years ago by deni

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:25 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2.5 to 3.5
  • Imp._reviewers changed from meddle to meddle, meddle

I think your implementation can pass.

3.5p (30m)

comment:26 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.