FRAME_FILLING_PATTERN_R0

[Astea]

wiki page: FRAME_FILLING_PATTERN_R0 - effort: 1d

[deyan]

Batch update from file query-1.csv

[danvisel]

Analysis redone - I'm not sure if I've done this correctly, as this is my first coding analysis.

[danvisel]

Reworked this with Pav's comments - thanks.

[deyan]

The analysis contains good overview, but since the effort of the task is small, the requirements should contain only what can be done in this revisions. The behavior will be little different from Sophie 1 since we do have filling type Image.

• In overview you should describe what is the expected behavior of the functionality in this revision or for the whole task. In task requirements you should point what exactly is expected in this revision.
• Choosing pattern should tile the image with it's default size. Due to the effort, resizing the image, rotating and the offset should be postponed (described in the overview section only)
• Since we don't currently support drag and drop, clicking on pattern should trigger an File Dialog to choose file from the OS (like insert image and filling:image) (this one is for the requirements - for future releases the DND is good, but should be in the overview section)

[danvisel]

Reworked analysis with Deyan's comments and Pav's help.

[danvisel]

time for reworking = 1h.

[deyan]

• The button may contain currently selected pattern
• The image is with it's default size tiled

[pap]

You are on the right path but there are some things that you should fix.

• ImmPattern should rather use our class ImmImage instead of BufferedImage. This way you will not have to wrtite the same things twice. You can use its transformaton methods too.
• Also I don't think it is needed to extend FileDialogInput.Kind enumeration. You'd better use the INSERT_IMAGE. This dialog should be refactored but in another task.
• Your test about immutability is a should test more things than now.

[pap]

• I accept the design even though it has some flaws.
• Note that you should also change the PageWorkArea to consider the new filling type
• I do not fully understand why do you need to create a pattern from file (I mean the constructor).
• Make sure that you fix the sizes of the BackgroundAndBorderHud and BackgroundPanel so that they display all 4 filling type selectors(this is a bit OS/java setup dependent).
• By default in the design you should submit some skeleton classes as much as they are needed for testing and not a fully working implementation.
• Next time try to do separate commits for the design part and the implementation part of the code.
• I will merge and review all of your code at implementation because what you submitted definitely differs from what the UML diagram states.
• Good luck and ask for help if you need to. So far you're doing well for a person new to the project.
• And a little note: Please make sure that you fill in the so called "custom fields" like Design_owners. You can ask about the way they should be used.

[meddle]

I'll pass the implementation, but I fixed somethings:

• First of all when clicking cancel on the file dialog for choosing the image for the pattern, an exception was thrown (that is and for the ImageFilling), I fixed that.
• Other thing is the strange constructor for pattern from file. The code was copied from the ImmImage file constructor and the ImmPattern ImmImmage constructor, I removed it.
• Why do you write first assertEquals(something) and then asserSame(the_same_thing), assertSame is stronger than assertEquals.

3p (80m)

[deyan]

Batch update from file query-obsoleted.csv