Ticket #808 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

TEXT_CHAINING_BEHAVIOUR_R0

Reported by: Astea Owned by: nenko
Priority: 3 Milestone: M04_PRE4
Component: TEXT_FLOWING Version: 2.0
Keywords: Cc:
Category: MAIN Effort: 1.5
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: dido, deyan, nenko Design_owners: nenko
Imp._owners: nenko, vlado, nenko Test_owners:
Analysis_reviewers: meddle, todor Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, meddle
Test_reviewers: Analysis_score: 4
Design_score: 3 Imp._score: 3
Test_score: 0

Description

wiki page: TEXT_CHAINING_BEHAVIOUR_R0 - effort: 1.5d

Change History

comment:1 Changed 14 years ago by dido

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to dido
  • Imp._score set to 0
  • Analysis_owners set to dido

comment:2 Changed 14 years ago by nenko

  • Ticket_group set to GROUP_BASE_MODEL_TEXT_R0

comment:3 Changed 14 years ago by boyan

  • Status changed from s1a_analysis_started to s2c_design_ok

Updating status of grouped task.

comment:4 Changed 14 years ago by boyan

  • Status changed from s2c_design_ok to new
  • Ticket_group changed from GROUP_BASE_MODEL_TEXT_R0 to GROUP_CHAINING_R0

changing group and status

comment:5 Changed 14 years ago by dido

  • Status changed from new to s1a_analysis_started

comment:6 Changed 14 years ago by deyan

  • Analysis_owners changed from dido to dido, deyan

comment:7 Changed 14 years ago by nenko

  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Analysis_owners changed from dido, deyan to dido, deyan, nenko

comment:8 Changed 14 years ago by nenko

  • Ticket_group GROUP_CHAINING_R0 deleted

comment:9 Changed 14 years ago by todor

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to todor
  • Analysis_score changed from 0 to 4

good analysis

comment:10 Changed 14 years ago by meddle

  • Analysis_reviewers changed from todor to meddle, todor

comment:11 Changed 14 years ago by nenko

  • Design_owners set to nenko
  • Owner changed from dido to nenko
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:12 Changed 14 years ago by nenko

  • Status changed from s2a_design_started to s2b_design_finished

comment:13 Changed 14 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3
  • Design_reviewers set to meddle

I think the design is understandable.

  • The test is not by our standards, so fix it for the implementation review.
  • No fake JavaDoc will be accepted on the implementation review.
  • There are messed revisions with other tasks, you must fix this issue for the implementation review. Only the code for this task will be merged on implementation OK, and our job is not to fix the messed up revisions. Classes for a task must be added in a separate revision.

I recommend if you can not give us revisions only with the code for that task, you make special temporary branch especially for it. But this messes with the revisions are impediments for the integration process, take our times and other reviews wait more...

3p (70m)

comment:14 Changed 14 years ago by nenko

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:15 Changed 13 years ago by nenko

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Imp._owners set to nenko, vlado

comment:16 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 1
  • Imp._reviewers set to meddle
  • ProObject in ResourceSpace can be only @own or in special occasions like yours @Shared... I talk for your properties in the HotTextFrameContent -> chainHead and chainNext.
  • You can do cyclic chaining between two frames???
  • You can choose not only text frames for the chaining???
  • Where is your image arrow.png, it's not in your revisions.
  • There is method to create a new book in the System tests, see other SystemTest and use it, or you will have to deal with the PropertiesDialog of the book.
  • Test your code if the tests run, if it's buildable with maven, if it's runnable with the true runners, both reader and author, if it breaks preview of book, inserting frames, if it breaks frame related actions like rotation and etc...

Last of all, I'm not a QA, next time your code doesn't run I'll fail your task and give you the exception without any other comments. We do code review when we see that the task is implemented and run without breaking anything... So on the next review be sure your code is OK. Synchronize with the trunk before fixing these bugs...

1p (70m)

comment:17 Changed 13 years ago by nenko

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners changed from nenko, vlado to nenko, vlado, nenko

comment:18 Changed 13 years ago by nenko

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Thanks for @Shared notation, however the current implementation uses ResourceRefs instead of it
  • Of course you can. This is R0 - this is not full implementation of chaining and yes, it has bugs
  • Well, I don't think so...I don't know you can. May be due to PageWorkArea's refactoring...
  • Obviously. Now it is. Before it was in my main private branch...
  • Thanks, this is fixed
  • This list is very helpful. Can you post somwhere in the wiki, may be in the Integrator's page

I won't comment whether you are a QA or not (you ASSURE code QUALITY, don't you). I don't see how tou can see that a task is breaking anytghing without reviewing it...Well, for now I can't say that my code is OK. Isn't this in the authority of the Integrators?

comment:19 Changed 13 years ago by nenko

Sorry for the misspelling. So:

  • I don't know you can = I don't know why you can
  • Can you post = Can you post it
  • tou = you

comment:20 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 1 to 2.5
  • Imp._reviewers changed from meddle to meddle, meddle

In ResourceSpace all the references to other resources are ResourceRefs, see GROUP_RESOURCE_R0 for details, so the problem with your design is that HotTextFrameContent is pro-object in the frame, so it's part of the frame's ResourceSpace and the hotTextResource in it must be ResourceRef... I'll fail this task and the other one GROUP_CHAINING_AND_HALOS_R0 to fix that in the both designs and then I'll review the both tasks as one, because they are connected if you want.

Code review and functionality testings on the next review

2.5p (20m)

comment:21 Changed 13 years ago by nenko

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:22 Changed 13 years ago by nenko

  • Status changed from s3a_implementation_started to s3b_implementation_finished

The other taks is implementation finished too.

comment:23 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2.5 to 3

Hmm the implementation is ok, I tested it, I added a persister for the chaining and now it's persistable :) But can we make the content a little bit smaller, may be to take out some of the auto properties in methods in helper class. Other thing is it needed the list to be double connected, from the design I don't like that.

3p (200m)

comment:24 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.