TEXT_CHAINING_BEHAVIOUR_R0

[Astea]

wiki page: TEXT_CHAINING_BEHAVIOUR_R0 - effort: 1.5d

[boyan]

Updating status of grouped task.

[boyan]

changing group and status

[todor]

good analysis

[meddle]

I think the design is understandable.

• The test is not by our standards, so fix it for the implementation review.
• No fake JavaDoc will be accepted on the implementation review.
• There are messed revisions with other tasks, you must fix this issue for the implementation review. Only the code for this task will be merged on implementation OK, and our job is not to fix the messed up revisions. Classes for a task must be added in a separate revision.

I recommend if you can not give us revisions only with the code for that task, you make special temporary branch especially for it. But this messes with the revisions are impediments for the integration process, take our times and other reviews wait more...

3p (70m)

[meddle]

• ProObject in ResourceSpace can be only @own or in special occasions like yours @Shared... I talk for your properties in the HotTextFrameContent -> chainHead and chainNext.
• You can do cyclic chaining between two frames???
• You can choose not only text frames for the chaining???
• Where is your image arrow.png, it's not in your revisions.
• There is method to create a new book in the System tests, see other SystemTest and use it, or you will have to deal with the PropertiesDialog of the book.
• Test your code if the tests run, if it's buildable with maven, if it's runnable with the true runners, both reader and author, if it breaks preview of book, inserting frames, if it breaks frame related actions like rotation and etc...

Last of all, I'm not a QA, next time your code doesn't run I'll fail your task and give you the exception without any other comments. We do code review when we see that the task is implemented and run without breaking anything... So on the next review be sure your code is OK. Synchronize with the trunk before fixing these bugs...

1p (70m)

[nenko]

• Thanks for @Shared notation, however the current implementation uses ResourceRefs instead of it
• Of course you can. This is R0 - this is not full implementation of chaining and yes, it has bugs
• Well, I don't think so...I don't know you can. May be due to PageWorkArea's refactoring...
• Obviously. Now it is. Before it was in my main private branch...
• Thanks, this is fixed
• This list is very helpful. Can you post somwhere in the wiki, may be in the Integrator's page

I won't comment whether you are a QA or not (you ASSURE code QUALITY, don't you). I don't see how tou can see that a task is breaking anytghing without reviewing it...Well, for now I can't say that my code is OK. Isn't this in the authority of the Integrators?

[nenko]

Sorry for the misspelling. So:

• I don't know you can = I don't know why you can
• Can you post = Can you post it
• tou = you

[meddle]

In ResourceSpace all the references to other resources are ResourceRefs, see GROUP_RESOURCE_R0 for details, so the problem with your design is that HotTextFrameContent is pro-object in the frame, so it's part of the frame's ResourceSpace and the hotTextResource in it must be ResourceRef... I'll fail this task and the other one GROUP_CHAINING_AND_HALOS_R0 to fix that in the both designs and then I'll review the both tasks as one, because they are connected if you want.

Code review and functionality testings on the next review

2.5p (20m)

[nenko]

The other taks is implementation finished too.

[meddle]

Hmm the implementation is ok, I tested it, I added a persister for the chaining and now it's persistable :) But can we make the content a little bit smaller, may be to take out some of the auto properties in methods in helper class. Other thing is it needed the list to be double connected, from the design I don't like that.

3p (200m)

[deyan]

Batch update from file query-obsoleted.csv