TEXT_STABLE_SELECTION_R0

[Astea]

wiki page: TEXT_STABLE_SELECTION_R0 - effort: 0.5d

[dido]

Analysis is fine but I have only one objection here.

• Should apply style to selection only. If nothing is selected, should apply styles from cursor position to the next character which has own style.

- The behavior in most application is to set style only to the word that contains the current position. If some characters contains custom styles (for example if in EXAMPLE' the first E is underlined and the X is bold), when the user set current position between M and P, and then change the size, all characters in "EXAMPLE" should change this property. However if he press bold, what should happen is that entire word 'EXAMPLE' should be bold.

• Don't know if this is for this task, but if I navigate using arrows and press ctrl key during that - I'll expect to position at the beginning of the next or previous word. However if I press shift key during that the behavior is different.
  • First case is to be in the beginning of the word and pres left arrow + ctrl + shift - this will select everything between current position and the beginning of the previous word(as expected)
  • Second case is to be in the beginning of the word and press right arrow + ctrl + shitf - this will select only the word and will set the current position at the end of the word.
  • As you can guess there should be a similar behavior if the initial position is in the end of a word.
  • Much more easy to explain case is when the initial position is in the middle(or in) a word. Then the selection is expected to be the remaining part of the word.

• Last case that doesn't present in the analysis is when I have a text selection and press left or right arrow. The current position should be placed in the beginning of the selection(for left arrow) or at the end(for right arrow). Please provide a solution for navigating with arrows in rotated text(Probably we should ignore the rotation and navigate as the text os not rotated ).

analysis review 2.5p (1h)

[dido]

• Defining word in sens of where it begins and end could be following:
  • Characters like !@#$%^{&*()_+-="';:,.<>?/`~\| and space character sets beginning and end of a word.}
  • However !@#$ is word.
  • EXA!@#PLE - are 3 words EXA !@# PLE
  • Space character and Tab character are not a word, even if they are one after another.

[deyan]

• By character with own style i mean default style too. This is now cleared.
• Navigating with arrows is not part of this task, but it is also clarified
• Dropping selection is explained again

[deyan]

• By character with own style i mean default style too. This is now cleared.
• Navigating with arrows is not part of this task, but it is also clarified
• Dropping selection is explained again

[pap]

Super review requested by nenko as the design is not actually finished.

[meddle]

• Ticket related notes:
  • Fill your custom fields! The design owner is you - diana, I'm doing it for you now, but is your responsibility to do it yourself.
• Design related notes:
  • What do you mean by "are not implemented" for some of the requirements? You design you talk about future implementation.
  • You can not decide to not implement requirements, the requirements are mandatory. If you want to shrink the scope the task should be super-reviewed to status 'new' and new analysis should be written with new requirements!
• Code notes:
  • Is a good idea strings that you use to test like "Lorem ipsum dolor sit amet, consectetur adipiscing elit. " in your test to be exported to variables.
  • You have some progress on your code quality stuff but see again GoodCodeExamples. Spacing? And for n-th time assertEquals methods have special parameters. The first is the EXPECTED value, and the second is the ACTUAL.
  • And again if you have some model classes used in the test you MUST add them to the changesets in the design phase.

2p (70m)

[boyan]

super reviewing to status new

[boyan]

starting reanalysing (dropping some requirements)

[boyan]

finished in about 15m

[dido]

Analysis is good enough for first revision
Review analysis 4p (1h)

[meddle]

• Code related notes:
  • I took a look at your "SelectPair" class and I was amazed... Why did you gave this class for the review?? It's full of bad code and the word for it is ugly. If this review wasn't in English I could express myself better but... I've got mental disorder...
• About the design... I think it passes, but I didn't understand from it where is the "selectedUnits" property or if there is such one at all...

3p (25m)

[meddle]

AssertionError with your implementation

[meddle]

There are many problems with that implementation:

• First of all your code is not working with the application because of the error in the attachment.
• Your test is not put in the branch correctly and of course is unmergeable.
• Run maven build and true runners first.
• I don't understand how you can select anything when the 'shift' key is not working properly in sophie at this moment. How did you test your code?
• You didn't read my design comments. Don't do that. Even if I pass designs they are important for the implementation.
• I think you will have to update/reimplement your logic in new branch.
• See that code : ​http://pastebin.asteasolutions.net/f4a4e50a8
  • The code for operation as select, delete, etc must look like that, simple.
  • I mean take out your repeating logic in such methods.

1p (65m)

[deyan]

The character ^{makes next comments unreadable...}

[meddle]

I'll fail this task automatically because it, the chaining tasks and the paragraph tasks are in big conflicts... I will review it with the paragraph task in the same times, because vlado will merge the two and fix the conflicts, because they are not trivial... The problem is not in the conflicts when merging, it's from the behavior with the chaining code, so the task will be merged very soon but together with the paragraphs...

May be when doing such connected tasks you will have to give me some sequence of them...

2.5p (1h)

[meddle]

Code problems:

• How many times I'll will have to tell you about the identation problem, I'll not let ugly code go to the trunk. I'll fix that now, but next time I'll fail tasks for ugly code! Ctrl+i in eclipse fixes the identation of selected code.
• Java asserts in JUnit tests again :(((((((((((
• Spacing!!! I'm glad that code can not be send directly into the trunk :)

And selecting words works differently from your implementation : if a word is selected and you try to select another one, the selection skips all the separators and goes to the end of the other one... I implemented that.

3p (80m)

[deyan]

Batch update from file query-obsoleted.csv