Ticket #855 (closed planned_task: obsolete)
BOOK_SEARCH_R0
| Reported by: | Astea | Owned by: | mitex |
|---|---|---|---|
| Priority: | 3 | Milestone: | M05_PRE5 |
| Component: | TEXT_TOOLS | Version: | 2.0 |
| Keywords: | Cc: | ||
| Category: | EXTRA | Effort: | 0.5 |
| Importance: | 0 | Ticket_group: | |
| Estimated Number of Hours: | 0 | Add Hours to Ticket: | 0 |
| Billable?: | yes | Total Hours: | 0 |
| Analysis_owners: | mitex, dido | Design_owners: | mitex, ivo |
| Imp._owners: | mitex | Test_owners: | |
| Analysis_reviewers: | deyan | Changelog: | |
| Design_reviewers: | meddle | Imp._reviewers: | meddle, meddle |
| Test_reviewers: | Analysis_score: | 4 | |
| Design_score: | 3 | Imp._score: | 3.5 |
| Test_score: | 0 |
Description
wiki page: BOOK_SEARCH_R0 - effort: 0.5d
Attachments
Change History
comment:1 Changed 16 years ago by mitex
- Owner changed from Astea to mitex
- Design_score set to 0
- Imp._score set to 0
- Test_score set to 0
- Analysis_score set to 0
comment:2 Changed 16 years ago by mitex
- Design_owners set to mitex, ivo
- Status changed from new to s1a_analysis_started
- Imp._owners set to mitex
- Analysis_owners set to mitex
comment:3 Changed 16 years ago by dido
- Status changed from s1a_analysis_started to s1b_analysis_finished
- Analysis_owners changed from mitex to mitex, dido
comment:5 follow-up: ↓ 7 Changed 16 years ago by deyan
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers set to deyan
4p
comment:7 in reply to: ↑ 5 Changed 16 years ago by mitex
- Analysis_score changed from 0 to 4
filling missing score (see deyan's review)
comment:8 Changed 16 years ago by mitex
- Status changed from s2a_design_started to s2b_design_finished
comment:9 Changed 16 years ago by meddle
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3
- Design_reviewers set to meddle
- Your BookSearchTest works with the resources terrible, fix it for the implementation, the entityId concept is bad and we remove it, ask the Resource-Redesign team how to work with the resources for your logic to work in the future.
- EventIds is bad name, think of a better one.
- There is something wrong with this SearchMatch... But may be at the implementation I will be able to tell you what...
3p (50m)
comment:10 Changed 16 years ago by mitex
- Status changed from s2c_design_ok to s3a_implementation_started
comment:11 Changed 16 years ago by mitex
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:12 Changed 16 years ago by meddle
- Status changed from s3b_implementation_finished to s2c_design_ok
- Imp._score changed from 0 to 2
- Imp._reviewers set to meddle
- Yeah I allowed you to drop the embedded books and the highlights, but the cursor moving?
- Behavior problems:
- You can see the results from invisible frames.
- There is a NullPointerException if you insert a script... You can not search in scripts, and may be it's OK for now but no exceptions allowed.
- You didn't delete the old SearchMatch.
- The implementation is not according the design:
- "Add "<<" and ">>" LogicR3Buttons below the text box and the search button."
- "Create static method that searches a string in an Element (Page or Group). " related things, I told you can drop the embedded groups, but update the design. And the grouped frames are important...
- The same applies to the -> "ITEM_SELECTED" part.
- When there are grouped frames you get the exception in the attachment -> search_exception.txt, when you search.
2p (100m)
comment:13 Changed 16 years ago by mitex
- Add Hours to Ticket set to 0
- Estimated Number of Hours set to 0
- Total Hours set to 0
- Status changed from s2c_design_ok to s3a_implementation_started
- Billable? set
comment:14 Changed 16 years ago by mitex
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:15 Changed 16 years ago by meddle
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 2 to 3.5
- Imp._reviewers changed from meddle to meddle, meddle
Notes :
- textToSearch.length() > 0, that is not a good check... use !textToSearch.isEmpty in the future.. because " " or " " are too empty strings...
- And yet again you didn't take seriously my past review... The search throws exception if we have no current book view (i.e. we have script for example...).
- I don't like that the line breaks are lost in the search... You have appended words instead...
- There is isEmpty() method in the java.util.Collections, use it instead collection.size > 0
- Delete not needed comments from the code...
Good work, works under reader and preview too.
3.5p (90m)
comment:16 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.
changed owner