SMOOTH_TEXT_RENDERING_R0

[Astea]

wiki page: SMOOTH_TEXT_RENDERING_R0 - effort: 2.5d

[deyan]

Batch update from file query-1.csv

[dido]

The implementation idea section is not clear enough. So I'll summarize this.

• First of all you give points to the tasks so they could be easily priorities.
• Hardness and Expected effectiveness are the main aspects of an issue. Like cost and value.
• The lower the summed number is, the higher is the priority of this issue.

So here are the attacked issues in order of their priority:

• Improve logging(3)
• Implement the issues commented as "performance"(5)
• Memoization (part of a path, edge, etc.)(5)
• Check for existing useless updates and reflowing (e.g. selecting the frame with highest z-order)(5)
• Check for large ammounts of objects cloning(5)
• Improve badness calculation(6)
• Refactor badness(7)

Analysis review 3.5p (1h)

[pap]

• Generally I like the design and its nice structure but I'll leave you some remarks to look at.
• It may be better to log the vertices with trace priority. If you take a look at http://sophie2.org/trac/wiki/LOGGING you'll see it is the level used to track the progress of a method.
• Same goes for edges in the ther method. But as we have some problems with the logging system you may also leave them as debug, but make the inital loggings(the one that say the method is called) to info level.
• The idea you express about changes is ok. GROUP_CHANGES_R0 is mostly in trunk as far as I know but there is much to do about them.
• The thing about page element selection is quite hacky but I think I can accept it, because it is reasonable.
• I think that if we refactor the HotTextSceneElement to be build like the other scene elements(having a DefaultHotTextSceneElement in the scenes module that has a synchronizing resource property) may improve things as it may change the layout not so often. I will be very glad if you do so.
• I think the idea about AtomKinds is nice but I find this deep nesting a bit confusing. Maybe you can make the AtomKind and its subclases with default visibility and add them in the package of atom(maybe create some subpackage). This is not mandatory.
• When I accept your design, it is not nice to change it anymore. Instead you should mention the differences in the Implementation section.
• I'm a bit sorry that you couldn't make it to the most effective according to the analysis improvement - the memoization.
• Good luck.

[meddle]

I'm think that is a really good improvement and thanks to the fast fix with the cursor. The was not so bad like quality.

4p (90m)

[deyan]

Batch update from file query-obsoleted.csv