Ticket #957 (closed planned_task: obsolete)
VIDEO_CONTENT_R0
| Reported by: | Astea | Owned by: | alex |
|---|---|---|---|
| Priority: | 3 | Milestone: | M03_PRE3 |
| Component: | MEDIA_CONTENT | Version: | 2.0 |
| Keywords: | Cc: | ||
| Category: | MAIN | Effort: | 2 |
| Importance: | 10 | Ticket_group: | GROUP_MEDIA_R0 |
| Estimated Number of Hours: | Add Hours to Ticket: | ||
| Billable?: | Total Hours: | ||
| Analysis_owners: | sriggins | Design_owners: | alex |
| Imp._owners: | alex | Test_owners: | |
| Analysis_reviewers: | tanya | Changelog: | |
| Design_reviewers: | tanya | Imp._reviewers: | |
| Test_reviewers: | Analysis_score: | 4 | |
| Design_score: | 3.5 | Imp._score: | 2.5 |
| Test_score: | 0 |
Description
wiki page: VIDEO_CONTENT_R0 - effort: 2d
Change History
comment:1 Changed 16 years ago by Tanya
- Category set to MAIN
- Design_score set to 0
- Imp._score set to 0
- Test_score set to 0
- Analysis_score set to 0
comment:3 Changed 16 years ago by sriggins
- Owner changed from Astea to sriggins
- Status changed from new to s1a_analysis_started
- Analysis_owners set to sriggins
comment:4 Changed 16 years ago by sriggins
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:5 Changed 16 years ago by tanya
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers set to tanya
- Analysis_score changed from 0 to 4
Very good, very helpful analysis.
comment:6 Changed 16 years ago by alex
- Design_owners set to alex
- Owner changed from sriggins to alex
- Status changed from s1c_analysis_ok to s2a_design_started
comment:7 Changed 16 years ago by alex
- Status changed from s2a_design_started to s2b_design_finished
comment:8 Changed 16 years ago by tanya
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3.5
- Design_reviewers set to tanya
- It is OK, but the unit test is missing.
comment:9 Changed 16 years ago by alex
- Status changed from s2c_design_ok to s3a_implementation_started
comment:10 Changed 16 years ago by alex
- Status changed from s3a_implementation_started to s3b_implementation_finished
- Imp._owners set to alex
comment:11 Changed 16 years ago by pap
- Status changed from s3b_implementation_finished to s2c_design_ok
- Imp._score changed from 0 to 2.5
- MediaBookResource has a field of type BinData. This should be a property. Generally you can have either an Immutable class or a ProObject that contains only properties and constants(final static things)
- This makes the getMedia method useless. Nevertheless its JavaDoc is not good
- Parameters are not explained in the JavaDoc of MediaBookResource
- The same applies to VideoBookResource
- When you were working on FrameFactory class you could've deleted one of the
createFrame methods. They both have same arguments but in different order.
- I don't understand the idea of the final modifier of the VideoContentView constructor argument
- The way you use the ValueProperty initialization for element in VideoContentViewClass is bad. If you're not going to set it make a final property or an auto property.
- In the VideoContentSceneElement the VideoHandler could be created as an anonymous class in the compute method. What you have done now is OK but it may become a smell.
- You write long test methods and having in mind that there are no comments they are very hard to read
- You kind of swap the arguments of assert* methods. You should first write the expected value, and after that the actual one.
- Just to note that when I asked you to commit thigs separately and link changesets I didn't mean commiting one file at a time. Actually changesets help with multiple files commit
comment:17 Changed 15 years ago by deyan
- Status changed from s2c_design_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.
