MEDIA_FRAME_CONTROLS_R0

[Astea]

wiki page: MEDIA_FRAME_CONTROLS_R0 - effort: 1d

[peko]

I think phrases like: "I disagree...", "I am not sure which task..." etc. should be part of a discussion not a content in the wiki. Other than this the analysis is pretty rich and very detailed. However for current revision we should shorten the requirements section since it is quite tedious for implementation at once. Overview may stay as a resource for future revisions but requirements section should be changed.

[boyan]

Consider the following things:

• The overview is too long. Although it is useful, this makes the analysis clumsy. Try to list the key topics as one-sentence bullets insead of descriptive paragraphs.
• I doubt 'adornments' is an appropriate word for the media controls. It's better to use a simplier word, for example 'additions'.
• The implementation idea doesn't provide any actual idea.

[pap]

The design has descent quality but there still some important issues to be fixed:

• First you should put graphical elements in the design phase(icons and stuff).
• You MUST have test/demo changeset in the design phase. It does need to pass/be working in that time. It may use only dummy interfaces and classes
• I don't like the names mouseDown(sounds like an event/event handler) and computeIsActive(has two verbs one after another)
• Perhaps it is not bad to make the icon property a final method.
• The names in the MediaManipulationLogic operation are tooooooo long
• If the elements of the VideoLogic and AudioLogic have a lot in common(or are the same) you may just merge them in one enumeration (for example MediaLogic).

[peko]

• Icons and stuff are linked in the design section.
  • Icons
  • Resources for the demo.
  • The demo class itself.
• Changesets are also linked there.
• mouseDown renamed to pressed
• computeIsActive renamed to computeActivated
• Icon property is now abstract and should be implemented in descendants since the play/pause button should have two possible icons.
• Renamed to MOUSE_PRESSED and MOUSE_RELEASED. It is clear what it is about since this corresponds to the MediaManipulationLogic.
• We now have a single Logic called MediaLogc. It is responsible for media adding and its playback.
• MediaManipulationViews are registered as extensions in the MainFuncMediaModule.

[meddle]

The design is fixed. It will pass but I have the following notes:

• There were some inconsistency because of the old ideas and the new ones.
• There were some bad JavadDocs and missed @author fields.
• There was bad spacing in the code.
• Аll the code for the implementation and the design is in one. That is bad.

3p (3h)

[meddle]

I reviewed the design and the implementation in one so 3p (1h), I think that may be that implementation is for greater mark, but the code quality was not very good...

[deyan]

Batch update from file query-obsoleted.csv