Ticket #965 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

MEDIA_FRAME_CONTROLS_R0

Reported by: Astea Owned by: peko
Priority: 3 Milestone: M05_PRE5
Component: MEDIA_CONTENT Version: 2.0
Keywords: Cc: peko
Category: EXTRA Effort: 1
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: sriggins, peko, nenko Design_owners: peko, nenko, peko
Imp._owners: peko Test_owners:
Analysis_reviewers: peko,boyan Changelog:
Design_reviewers: pap, meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3
Design_score: 3 Imp._score: 3
Test_score: 0

Description

wiki page: MEDIA_FRAME_CONTROLS_R0 - effort: 1d

Change History

comment:1 Changed 13 years ago by sriggins

  • Owner changed from Astea to sriggins
  • Design_score set to 0
  • Imp._score set to 0
  • Test_score set to 0
  • Analysis_score set to 0

comment:2 Changed 13 years ago by sriggins

  • Status changed from new to s1a_analysis_started
  • Analysis_owners set to sriggins

comment:3 Changed 13 years ago by sriggins

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 13 years ago by peko

  • Ticket_group set to GROUP_MEDIA_R0

comment:5 Changed 13 years ago by peko

  • Status changed from s1b_analysis_finished to new
  • Analysis_reviewers set to peko
  • Analysis_score changed from 0 to 2

I think phrases like: "I disagree...", "I am not sure which task..." etc. should be part of a discussion not a content in the wiki. Other than this the analysis is pretty rich and very detailed. However for current revision we should shorten the requirements section since it is quite tedious for implementation at once. Overview may stay as a resource for future revisions but requirements section should be changed.

comment:6 Changed 13 years ago by peko

  • Owner changed from sriggins to peko
  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from sriggins to sriggins, peko, nenko

comment:7 Changed 13 years ago by peko

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:8 Changed 13 years ago by boyan

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers changed from peko to peko,boyan
  • Analysis_score changed from 2 to 3

Consider the following things:

  • The overview is too long. Although it is useful, this makes the analysis clumsy. Try to list the key topics as one-sentence bullets insead of descriptive paragraphs.
  • I doubt 'adornments' is an appropriate word for the media controls. It's better to use a simplier word, for example 'additions'.
  • The implementation idea doesn't provide any actual idea.

comment:9 Changed 13 years ago by peko

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:10 Changed 13 years ago by peko

  • Design_owners set to peko, nenko
  • Status changed from s2a_design_started to s2b_design_finished

comment:11 Changed 13 years ago by nenko

  • Ticket_group GROUP_MEDIA_R0 deleted

comment:12 Changed 13 years ago by pap

  • Cc peko added
  • Design_score changed from 0 to 2
  • Design_reviewers set to pap
  • Status changed from s2b_design_finished to s1c_analysis_ok

The design has descent quality but there still some important issues to be fixed:

  • First you should put graphical elements in the design phase(icons and stuff).
  • You MUST have test/demo changeset in the design phase. It does need to pass/be working in that time. It may use only dummy interfaces and classes
  • I don't like the names mouseDown(sounds like an event/event handler) and computeIsActive(has two verbs one after another)
  • Perhaps it is not bad to make the icon property a final method.
  • The names in the MediaManipulationLogic operation are tooooooo long
  • If the elements of the VideoLogic and AudioLogic have a lot in common(or are the same) you may just merge them in one enumeration (for example MediaLogic).

comment:13 Changed 13 years ago by peko

  • Design_owners changed from peko, nenko to peko, nenko, peko
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:14 Changed 13 years ago by peko

  • Status changed from s2a_design_started to s2b_design_finished
  • Icons and stuff are linked in the design section.
    • Icons
    • Resources for the demo.
    • The demo class itself.
  • Changesets are also linked there.
  • mouseDown renamed to pressed
  • computeIsActive renamed to computeActivated
  • Icon property is now abstract and should be implemented in descendants since the play/pause button should have two possible icons.
  • Renamed to MOUSE_PRESSED and MOUSE_RELEASED. It is clear what it is about since this corresponds to the MediaManipulationLogic.
  • We now have a single Logic called MediaLogc. It is responsible for media adding and its playback.
  • MediaManipulationViews are registered as extensions in the MainFuncMediaModule.

comment:15 Changed 13 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2 to 3
  • Design_reviewers changed from pap to pap, meddle

The design is fixed. It will pass but I have the following notes:

  • There were some inconsistency because of the old ideas and the new ones.
  • There were some bad JavadDocs and missed @author fields.
  • There was bad spacing in the code.
  • Аll the code for the implementation and the design is in one. That is bad.

3p (3h)

comment:16 Changed 13 years ago by peko

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:17 Changed 13 years ago by peko

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Imp._owners set to peko

comment:18 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to meddle

I reviewed the design and the implementation in one so 3p (1h), I think that may be that implementation is for greater mark, but the code quality was not very good...

comment:19 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.