Ticket #982 (closed planned_task: obsolete)
COMMENT_FRAMES_R0
| Reported by: | Astea | Owned by: | kyli |
|---|---|---|---|
| Priority: | 3 | Milestone: | M05_PRE5 |
| Component: | DOMAIN_ELEMENTS | Version: | 2.0 |
| Keywords: | Cc: | ||
| Category: | EXTRA | Effort: | 2.5 |
| Importance: | 0 | Ticket_group: | |
| Estimated Number of Hours: | 0 | Add Hours to Ticket: | 0 |
| Billable?: | yes | Total Hours: | 0 |
| Analysis_owners: | dido, kyli | Design_owners: | kyli |
| Imp._owners: | kyli | Test_owners: | |
| Analysis_reviewers: | deyan,deyan,deyan | Changelog: | |
| Design_reviewers: | meddle, meddle | Imp._reviewers: | meddle |
| Test_reviewers: | Analysis_score: | 4 | |
| Design_score: | 3.5 | Imp._score: | 3.5 |
| Test_score: | 0 |
Description
wiki page: COMMENT_FRAMES_R0 - effort: 2.5d
Change History
comment:1 Changed 16 years ago by dido
- Status changed from new to s1a_analysis_started
- Analysis_score set to 0
- Test_score set to 0
- Design_score set to 0
- Owner changed from Astea to dido
- Imp._score set to 0
- Analysis_owners set to dido, kyli
comment:2 Changed 16 years ago by kyli
- Status changed from s1a_analysis_started to s1b_analysis_finished
Done.
comment:3 Changed 16 years ago by deyan
- Status changed from s1b_analysis_finished to new
- Analysis_reviewers set to deyan
- Analysis_score changed from 0 to 2.5
Generally, I like the analysis, but there are some open questions:
- Why comment frames miss anchor and link halos? I don't think this is needed
- Why comment frames live on server only? The functionality in Sophie1 allowed the book to be offline and the comments were saved into the book. I think it is usable feature and we can implement it.
- Why the author should moderate comments? Probably it is better solution to have permissions for this, you have a book, but I have the rights to moderate specific comment stream. This however is not part of this revision of the task
Please synchronize with Milo offline commenting functionality.
comment:4 Changed 16 years ago by kyli
- Owner changed from dido to kyli
- Status changed from new to s1a_analysis_started
comment:5 Changed 16 years ago by kyli
- Status changed from s1a_analysis_started to s1b_analysis_finished
The links' requirement is removed, comment frame's location is not so specified already (but for this revision it will be implemented only on the server). The problem about permissions is not clear to me, since they are part of a completely different task, which is not implemented. So, I think it could not be considered at this time.
comment:6 Changed 16 years ago by deyan
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers changed from deyan to deyan,deyan
- Analysis_score changed from 2.5 to 4
The last thing - the attached screenshot supposes that the comment frame will look like a dialog, this is improper for me. It will be better if the controls look like media controls for example.
comment:7 Changed 16 years ago by kyli
- Status changed from s1c_analysis_ok to s2a_design_started
- Design_reviewers set to kyli
Starting..
comment:8 Changed 16 years ago by kyli
- Status changed from s2a_design_started to s2b_design_finished
comment:9 Changed 16 years ago by meddle
- Design_owners set to kyli
- Design_score changed from 0 to 3.5
- Design_reviewers changed from kyli to meddle
- Status changed from s2b_design_finished to s2c_design_ok
Hmm no design related code provided, I looked into your branch and didn't see anything new. Tests are written though, you test adding and persisting comments, the CommentWebServiceTest is strange, this Thread.sleep is something like heuristic manner for testing is not good, the server could start slower in the future...
About the model I don't like that it's fake, but at this moment works.
This CommentManager must not repeat logic. Write it to do only special comment related stuff. If you have the logic to delete comments, test it.
You are the design owner, not the reviewer...
3.5p (45m)
comment:10 Changed 16 years ago by kyli
- Status changed from s2c_design_ok to s3a_implementation_started
- Imp._owners set to kyli
comment:11 Changed 16 years ago by kyli
- Add Hours to Ticket set to 0
- Estimated Number of Hours set to 0
- Total Hours set to 0
- Status changed from s3a_implementation_started to new
- Billable? set
Should be re-implemented in the new trunk.
comment:12 Changed 16 years ago by kyli
- Status changed from new to s1a_analysis_started
Starting analysis again.
comment:13 Changed 16 years ago by kyli
- Status changed from s1a_analysis_started to s1b_analysis_finished
Finished in 1h (together with the discussions about it).
comment:14 Changed 16 years ago by deyan
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers changed from deyan,deyan to deyan,deyan,deyan
Good analysis
comment:16 Changed 16 years ago by kyli
- Status changed from s2a_design_started to s2b_design_finished
Done in several months.
comment:17 Changed 16 years ago by meddle
- Status changed from s2b_design_finished to s2c_design_ok
- Design_reviewers changed from meddle to meddle, meddle
I think the ideas are good, but for these things you could have put one UML Diagram because it's a new hierarchy. I think I like the code, you could have linked all the classes though...
And how will the comment frames look? There is no picture neither in the analysis or in the design...I think the analysis guys should draw such thing :)
3.5p (1h)
comment:18 Changed 16 years ago by kyli
- Status changed from s2c_design_ok to s3a_implementation_started
comment:19 Changed 16 years ago by kyli
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:20 Changed 16 years ago by meddle
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 3.5
- Imp._reviewers set to meddle
So the implementation is fine, I have no comments... The fix with the search palette took us some time though...
3.5p (50m)
comment:21 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
