Ticket #1040 (closed planned_task: obsolete)
BROWSER_CONTENT_BASIC_R2
| Reported by: | Astea | Owned by: | sveto |
|---|---|---|---|
| Priority: | 3 | Milestone: | M11_BETA3 |
| Component: | COMPOSITE_ELEMENTS | Version: | 2.0 |
| Keywords: | Cc: | sveto | |
| Category: | EXTRA | Effort: | 2 |
| Importance: | 0 | Ticket_group: | |
| Estimated Number of Hours: | 16 | Add Hours to Ticket: | 0 |
| Billable?: | yes | Total Hours: | 0 |
| Analysis_owners: | sveto | Design_owners: | sveto |
| Imp._owners: | sveto | Test_owners: | |
| Analysis_reviewers: | dido | Changelog: | |
| Design_reviewers: | pap,meddle | Imp._reviewers: | meddle |
| Test_reviewers: | Analysis_score: | 3 | |
| Design_score: | 3 | Imp._score: | 2 |
| Test_score: | 0 |
Description
wiki page: BROWSER_CONTENT_BASIC_R2 - effort: 1.5d
Change History
comment:1 Changed 16 years ago by sveto
- Status changed from new to s1a_analysis_started
- Total Hours set to 0
- Analysis_score set to 0
- Cc sveto added
- Test_score set to 0
- Milestone changed from M09_BETA1 to M11_BETA3
- Add Hours to Ticket set to 0
- Design_score set to 0
- Billable? set
- Owner changed from Astea to sveto
- Estimated Number of Hours set to 16
- Effort changed from 1.5 to 2
- Imp._score set to 0
- Analysis_owners set to sveto
comment:2 Changed 16 years ago by sveto
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:3 Changed 16 years ago by dido
- Cc dido added
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers set to dido
- Analysis_score changed from 0 to 3
- Create a native C++ wrapper for delivery of browser content. - this should be part of the overview or in requirements. Please fix it.
- There is no GROUP_WRAPPERS_R0 page, please created and field it before sending this for design review.
Analysis Reviewed 3p (20m)
comment:4 Changed 16 years ago by sveto
- Design_owners set to sveto
- Status changed from s1c_analysis_ok to s2a_design_started
comment:5 Changed 16 years ago by sveto
- Status changed from s2a_design_started to s2b_design_finished
(8h)
comment:6 Changed 16 years ago by pap
- Cc dido removed
- Design_score changed from 0 to 3
- Design_reviewers set to pap,meddle
- Status changed from s2b_design_finished to s2c_design_ok
- About page loading it is better to display the result no matter whether the page was loaded successfully, is still being loaded or failed loading. Just tell it to load and then grabbing images constantly.
- You have some strange files commited in the repository and some of them are frightening me.
- GPL COPYNG file
- Copyright notes in the beggining of files (browser.h)
- .kdev files (maybe you can svn:ignore them if you use KDevelop) I am not so sure about that.
- I don't see any sens in making Browser's destructor virtual.
- You have magic numbers Browser::Browser() - "wv->resize(800, 600);"
- I see a pointer given as an argument to a method is usually considered a bad practice (Browser::loadUrl, LoadCommand::LoadCommand).
- Not deleting in destrucotrs (LoadCommand::~LoadCommand() ).
- Document code (Java and C++).
- Generally be carefull with C++ memory management.
- Using an external site as google in the test is not a good idea. You'd better use some local HTML file accessed via the file protocol.
- It may be nice to document command and response IDs in the wiki page.
- The structure of all antive projects, including yours, is quite strange and unsynchronized.
comment:7 Changed 16 years ago by sveto
- Status changed from s2c_design_ok to s3a_implementation_started
- Imp._owners set to sveto
comment:8 Changed 16 years ago by sveto
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:9 Changed 16 years ago by meddle
- Status changed from s3b_implementation_finished to s2c_design_ok
- Imp._score changed from 0 to 2
- Imp._reviewers set to meddle
I know that this is already in the trunk, and I know that there is nothing I can do to fix the bugs and to pass this task through the process again but...
The browser frame is practically unusable, your key command don't work (you can not search in google for example), I keep receiving InvocationTargetExceptions and broken pipes in thousands different ways... But I think you can use this task to stabilize the browser and pass the fixing code through the process...
2p (1h)
comment:10 Changed 15 years ago by deyan
- Status changed from s2c_design_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.
