Ticket #1682 (closed unplanned_task: obsolete)
GROUP_PRO_LIB_PERFORMANCE_R0
| Reported by: | gogov | Owned by: | gogov |
|---|---|---|---|
| Priority: | major | Milestone: | M06_ALPHA1 |
| Component: | PRO_LIB_CORE | Version: | 2.0 |
| Keywords: | performance, prolib | Cc: | |
| Category: | CORE | Effort: | |
| Importance: | 90 | Ticket_group: | |
| Estimated Number of Hours: | Add Hours to Ticket: | ||
| Billable?: | Total Hours: | ||
| Analysis_owners: | gogov | Design_owners: | gogov |
| Imp._owners: | gogov | Test_owners: | |
| Analysis_reviewers: | meddle | Changelog: | |
| Design_reviewers: | meddle | Imp._reviewers: | meddle |
| Test_reviewers: | Analysis_score: | 3.5 | |
| Design_score: | 3 | Imp._score: | 4.5 |
| Test_score: | 0 |
Description (last modified by gogov) (diff)
Change History
comment:1 Changed 16 years ago by gogov
- Category changed from unknown to CORE
- Importance set to 90
- Component changed from uncategorized to PRO_LIB_CORE
- Keywords performance, prolib added
- Milestone set to M05_PRE5
comment:2 Changed 16 years ago by gogov
- Type changed from bug to unplanned_task
- Milestone changed from M05_PRE5 to M06_ALPHA1
comment:3 Changed 16 years ago by gogov
- Owner set to gogov
- Status changed from new to s1a_analysis_started
comment:5 Changed 16 years ago by gogov
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:7 Changed 16 years ago by meddle
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers set to meddle
- Analysis_score changed from 0 to 3.5
It's good, but you can add some detailed info about the aspects idea in the "Implementation idea" section. 3.5 (15m)
comment:9 Changed 16 years ago by gogov
- Status changed from s2a_design_started to s2b_design_finished
comment:12 Changed 16 years ago by meddle
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3
- Design_reviewers set to meddle
The design and the tests are great, and I will pass it, but I'll give it only 3p because:
- In the implementation you'll have to remove the @SuppressWarnings("all") annotations and to write javadoc, otherwise I will not pass it!
- You have some code in the ReflectionUtil that finds annotation for a method traversing its hierarchy up and some inner class.
- There are some malformed javadocs especially on the getters.
3p (70m)
comment:13 Changed 16 years ago by gogov
- Status changed from s2c_design_ok to s3a_implementation_started
comment:14 Changed 16 years ago by gogov
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:16 Changed 16 years ago by meddle
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 4.5
- Imp._reviewers set to meddle
The implementation is OK and merged to the trunk, there is visible start up time optimization.
4.5p (40m)
comment:17 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.
