Ticket #1683 (closed bug: fixed)

Opened 10 years ago

Last modified 10 years ago

UNPLANNED_TEST_FIX_R0

Reported by: kyli Owned by: kyli
Priority: major Milestone: M07_ALPHA2
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: kyli Design_owners: kyli
Imp._owners: kyli Test_owners:
Analysis_reviewers: pap Changelog:
Design_reviewers: pap Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 4 Imp._score: 3
Test_score: 0

Description (last modified by boyan) (diff)

Change History

comment:1 Changed 10 years ago by kyli

  • Description modified (diff)

comment:2 Changed 10 years ago by kyli

  • Owner set to kyli
  • Status changed from new to s1a_analysis_started

comment:3 Changed 10 years ago by kyli

  • Status changed from s1a_analysis_started to s1b_analysis_finished

done in 15m.

comment:4 Changed 10 years ago by pap

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 0 to 3.5

OK but you need to look at all automatic tests (not the Unit tests only).

  • Probably it is a good idea to revise which of the tests are unit and which have to be changed to Integration.
  • Perhaps you should look if some tests need to be moved to other modules.

comment:5 Changed 10 years ago by pap

  • Analysis_reviewers set to pap

Adding An-re owner

comment:6 Changed 10 years ago by kyli

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:7 Changed 10 years ago by kyli

  • Design_owners set to kyli
  • Status changed from s2a_design_started to s2b_design_finished

done in one night.

comment:8 Changed 10 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to pap

Good enough for such a huge task.

comment:9 Changed 10 years ago by kyli

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to kyli

comment:10 Changed 10 years ago by kyli

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Not fully completed due to lack of time, hope this is enough for the first revision.

comment:11 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to meddle

I will pass this implementation, because it fixes quite a few tests, but:

  • For the next revision all the setUp methods have to be annotated with @Before and all the tearDown with @After. I fixed many tests myself to have this.
  • There still are present failing tests that the implementation section does not describe.
  • Remove all the @SupressWarnings("all") annotations on the tests and add javadoc/fix them.
  • Add new tests for the logic that is without tests.
  • Some of the javadocs were left malformed.

3p (4.5h)

comment:12 Changed 10 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to fixed

comment:13 Changed 10 years ago by boyan

  • Description modified (diff)
  • Summary changed from UNPLANNED_UNIT_TEST_FIX_R0 to UNPLANNED_TEST_FIX_R0

comment:14 Changed 10 years ago by boyan

  • Description modified (diff)
Note: See TracTickets for help on using tickets.