GROUP_APP_SERVER_RESOURCE_ACCESS_R0

[kyli]

GROUP_APP_SERVER_RESOURCE_ACCESS_R0

Ticket	Summary	Effort	Status
#98	PLUGIN_DECOMPOSITION_R3	1.5	closed
#515	APP_SERVER_RESOURCE_BROWSER_LISTING_R0	1	closed
#519	APP_SERVER_RESOURCE_BROWSER_ACTIONS_R0	1	closed
#1257	S2S_WEB_SERVICES_R1	3	closed
#1266	S2S_FACADE_RESOURCE_ACCESS_R0	1	closed

[boyan]

starting analysis

[boyan]

finished

[deyan]

• Some of the task requirements are design-oriented - an analysis should not contain what will be in which module, but what is the benefit of this. You can keep these things in Implementation idea, but stating them as requirements makes the analysis implementation dependent.
• Since this is first revision of this task, it is a good idea to make an overview of the whole task (ideas about next releases).

[deyan]

It is also important to add a Milestone for the group ticket, otherwise the ticket is not shown in the iteration page.

[kyli]

Finished again. The overview could not be expanded, since there is no specification about connectivity (at least I couldn't find), maybe it will be generated with the other APP_CONNECTIVITY tasks.

[deyan]

The design still looks too technical. The overview still does not contain overview of the whole task, which is wrong in my opinion - features need to be designed thinking for all of the features.

[kyli]

finished design

[meddle]

• Important design notes:
  • First of all the Facade definition (the interfaces of the facade) must be moved to the org.sophie2.bas.connectivity package because despite the server core it too provides a facade implementation and it's more appropriate the server.core package to depend to a "base" package.
  • About the Resource facade. I agree at this moment the too methods work for the requirements but:
    • The getResourceList() method returns ResourceRef statement is not full it returns "absolute" ResourceRefs, without entity ids, created on the server with ResourceRef#getAbsoluteReference(String absoluteLocation). Only that is needed for cathing a resource from the server
    • getResource(String entityId); That is wrong, on the server we work with URLs mostly, thats why use getResource(String absoluteLocation).
  • All the methods in the ResourceServeice is appropriate to accept absoluteLocation and not entityId or Resource/ResourceRef.
  • deleteBook is left? Why not deleteResource? Ahaaa in the code is renamed :) But not in the design documentation...
  • Use the Persistence for serializing the ResourceRefs when you sending them to the client as XML, and then on the client use the persistence again to deserialize them.
  • Change the Daos with my notes about the services :)
• Other ideas:
  • Maybe soon will be time to rename the Services, Managers, Daos to more meaningful things, that is old names that I thought at some point...
• For the code at this moment I have no special notes, at the implementation review it will be checked in details...

[boyan]

removing cc

[kyli]

Thanks for the review. The following things were changed:

• A brief explanation of the current facade location has been added.
• entityIds have been replaced by absoluteLocation in the design.
• For bookService and BookDao, a requirement has been added to rename the *book* methods to *resource*.
• Usage of XMLManagementService for resourceRef sending was replaced by the current persistence.

[meddle]

• Notes:
  • Hmm the absolute ResourceRef has only the absolute location, but form it you can get the name of course.
  • And NO, the server core and the server facade are two different things, in the implementation don't merge them in one. I'll not pass such an implementation and Pap will not pass it too. The core is the main logic in the server, the ServerFacade is simple implementation of the Facade that uses part of this core logic over the core!
  • You will change the MemoryDatabasemanager... So don't broke the user/group logic that works now and make sure the web interface for working with books/resources work without exceptions, synchronize with Vlado and the server MUST run with the True run configuration.

3p (20m)

[kyli]

Actually started implementation 2 days ago.

[meddle]

The task will be passed to the trunk.

• For the next task -> http://sophie2.org/trac/ticket/1214 these thing must be fixed:
  • Write the JavaDoc of all the server classes (in all the modules) like described in GoodCodeExamples. Especially for these that have "TODO" for that.
  • Replace all the e.printStackTrace(); lines with appropriate log.
  • Fix all the AssertationErrors that are logged when running some of the tests.
• Bad thing in the implementation:
  • Think of a way to fix the book location to be something like ​http://server_domain/resources/SomeBook.sjrb...
  • Think of a way to remove the ugly code when starting the MemoryDatabaseManager.

3p (230m)

[deyan]

Batch update from file query-obsoleted.csv