Ticket #1710 (closed bug: fixed)
TLID:796 Links cannot be saved and previewed
Reported by: | deyan | Owned by: | kyli |
---|---|---|---|
Priority: | critical | Milestone: | M09_BETA1 |
Component: | uncategorized | Version: | 2.0 |
Keywords: | Cc: | ||
Category: | unknown | Effort: | |
Importance: | Ticket_group: | ||
Estimated Number of Hours: | 0 | Add Hours to Ticket: | 0 |
Billable?: | yes | Total Hours: | 0 |
Analysis_owners: | danvisel, deyan | Design_owners: | kyli |
Imp._owners: | kyli | Test_owners: | deyan |
Analysis_reviewers: | meddle | Changelog: | |
Design_reviewers: | Imp._reviewers: | mira | |
Test_reviewers: | Analysis_score: | 3.5 | |
Design_score: | 3 | Imp._score: | 4 |
Test_score: | 4 |
Description (last modified by deyan) (diff)
Steps
- Open Sophie. Create a new book
- Go to page 2. Insert a frame.
- Create a link: On mouse enter, go to page 1.
- Save the book As
- Reload the book
- Test the link in preview mode
Expected Results
- A frame is inserted
- The link is created
- The book is saved with the desired filename
- The book is loaded
- The link is working correctly
Attachments
Change History
comment:1 Changed 16 years ago by deyan
- Description modified (diff)
The attached error appears when trying to load the attached book
comment:2 Changed 16 years ago by deyan
- Owner set to deyan
- Status changed from new to s1a_analysis_started
- Analysis_owners changed from deyan to danvisel, deyan
- Milestone set to M09_BETA1
comment:3 Changed 16 years ago by deyan
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:4 Changed 16 years ago by meddle
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers set to meddle
- Analysis_score changed from 0 to 3.5
The description of the bug is clean enough for me...
comment:5 Changed 16 years ago by kyli
- Design_owners set to kyli
- Owner changed from deyan to kyli
- Status changed from s1c_analysis_ok to s2a_design_started
Starting.
comment:6 Changed 16 years ago by kyli
Links are actually previewed correctly, they just cannot be saved. This is because they do not have associated persisters - some have to be written. The following classes will be needed: LinkPersister (link|storage|r3), LinkRulePersister (link-rule|storage|r3), LinkTriggerPersister (link-trigger|storage|r3), LinkActionPersister (link-action|storage|r3), also for every link action we will need different persister - the target of the action may vary.
comment:7 Changed 16 years ago by kyli
- Status changed from s2a_design_started to s2b_design_finished
- Imp._owners set to kyli
Done. Changeset: [3778]
comment:8 Changed 16 years ago by kyli
- Status changed from s2b_design_finished to s2c_design_ok
Moving to im_fi.
comment:9 Changed 16 years ago by kyli
- Status changed from s2c_design_ok to s3a_implementation_started
comment:10 Changed 16 years ago by kyli
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:11 Changed 16 years ago by mira
- Status changed from s3b_implementation_finished to s2c_design_ok
- Imp._score changed from 0 to 2
- Imp._reviewers set to mira
- You should have separate persisters for page and frame since there are two different types of trigers. There is no point in merging them in a factory method createAppropriateRule(). If we add text trigers we would need to add them here and it is better to be able to just write one more persister.
- It is better to use the PropRef instead of ValueRef with trivial set and get.
- LinkRulePersisterTest is empty
comment:12 Changed 16 years ago by kyli
- Add Hours to Ticket set to 0
- Estimated Number of Hours set to 0
- Total Hours set to 0
- Status changed from s2c_design_ok to s3c_implementation_ok
- Billable? set
Fixed.
comment:13 Changed 16 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Test_score changed from 0 to 4
- Test_owners set to deyan
- Design_score changed from 0 to 3
- Resolution set to fixed
- Imp._score changed from 2 to 4
fixed