Ticket #1711 (closed bug: fixed)

Opened 11 years ago

Last modified 10 years ago

Tweak: Page and frame borders

Reported by: deyan Owned by: sriggins
Priority: critical Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: danvisel Design_owners: sriggins
Imp._owners: sriggins Test_owners:
Analysis_reviewers: deyan Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 4
Design_score: 2 Imp._score: 2
Test_score: 0

Description (last modified by sriggins) (diff)

Currently, the default page and frame borders are 10px red. Turning off the 10-pixel red border that all frames and pages currently have would make it look better.

BUG_PAGE_AND_FRAME_BORDERS?

Change History

comment:1 Changed 11 years ago by deyan

  • Priority changed from major to critical
  • Status changed from new to s1c_analysis_ok
  • Analysis_score changed from 0 to 4

comment:2 Changed 11 years ago by deyan

  • Analysis_owners changed from dan to danvisel
  • Milestone set to M09_BETA1

comment:3 Changed 11 years ago by sriggins

  • Description modified (diff)

comment:4 Changed 11 years ago by sriggins

  • Description modified (diff)

Dan, do you want them to be black and 1 pixel defaults?

comment:5 Changed 11 years ago by sriggins

  • Design_owners set to sriggins
  • Owner set to sriggins
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:6 Changed 11 years ago by danvisel

Borders: I would want them to be black and 0 pixel defaults; otherwise for demo books you have to remove the border on every frame. Borders aren't actually something that get used very often.

comment:7 Changed 11 years ago by danvisel

Clarification for Steve: we should turn on borders so users can see the edges of frames rather than using borders to do that.

comment:8 Changed 11 years ago by sriggins

  • Status changed from s2a_design_started to s2b_design_finished

Page class: change BorderStyle compute() to create the border directly, instead of via createDefault, with a frame of 1 pixel black
Frame class: change BorderStyle compute() to create the border directly, instead of via createDefault, with a frame of 0 pixel black
BookView class: Change DEFAULT_OUTLINE_MODE to true

comment:9 Changed 11 years ago by sriggins

  • Status changed from s2b_design_finished to s2c_design_ok

comment:10 Changed 11 years ago by sriggins

  • Status changed from s2c_design_ok to s3a_implementation_started

/branches/private/sriggins/BUG_1711_Page_and_frame_borders/

(sorry about the camel case on this one)

Ready for review

comment:11 Changed 11 years ago by sriggins

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:12 Changed 11 years ago by sriggins

Updated page class to have no border

comment:13 Changed 11 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._owners set to sriggins
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 2
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 2

Steve it's not good to call new BorderStyle(0, ImmColor.BLACK, new ImmInsets(1)) every time on compute of the AutoProperty, it will create new object every time when the template field value is changed.

  • Other notes:
    • I don't like the fact that you hard coded the default values in the properties, why don't change the createDefault() method instead, or more correctly the constants DEFAULT_BORDER_THICKNESS and DEFAULT_BORDER_COLOR. The method is static final, which is good.
    • Changing DEFAULT_OUTLINE_MODE to true is good idea. Just take in mind my comment and I'll pass the bug.

comment:14 Changed 10 years ago by vanya

  • Status changed from s2c_design_ok to s1c_analysis_ok
  • Total Hours set to 0
  • Billable? set
  • Add Hours to Ticket set to 0
  • Milestone changed from M09_BETA1 to M12_RELEASE
  • Estimated Number of Hours set to 0

comment:15 Changed 10 years ago by deyan

  • Status changed from s1c_analysis_ok to closed
  • Resolution set to fixed

fixed

Note: See TracTickets for help on using tickets.