Ticket #1723 (closed unplanned_task: obsolete)

Opened 10 years ago

Last modified 9 years ago

UNPLANNED_TEST_FIX_R1

Reported by: boyan Owned by: boyan
Priority: major Milestone: M09_BETA1
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort: 3
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: boyan Design_owners: boyan
Imp._owners: boyan Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: meddle Imp._reviewers: mira
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 3.5
Test_score: 0

Description

Change History

comment:1 Changed 10 years ago by boyan

  • Status changed from new to s1a_analysis_started

starting quick analysis

comment:2 Changed 10 years ago by boyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

Quick analysis:

The purpose of this task is to reduce the number of failing tests and to improve the code quality of tests. The goal at this revision will be to clean up the base modules or as much as possible of them. The wiki page created will not contain the usual analysis, design and implementation sections. Instead, it will only provide a description of the changes made in each module with a corresponding changeset, similar to the table in UNPLANNED_UNIT_TEST_FIX_R0.

comment:3 Changed 10 years ago by boyan

  • Design_owners set to boyan
  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_owners set to boyan

moving task status up, starting quick design

comment:4 Changed 10 years ago by boyan

  • Status changed from s1c_analysis_ok to s2a_design_started

Quick design:

The following things should be achieved:

  • No failing tests.
  • No fake tests.
  • No @SuppressWarnings("all") annotation.
  • @Before, @After, @Test annotations.
  • Improved Javadoc.
  • Code quality (spacing, order of arguments(expected/actual), etc.)

The first bullet might require code refactoring. Changes will be described in the wiki page. No new tests will be written.

comment:5 Changed 10 years ago by boyan

  • Status changed from s2a_design_started to s2b_design_finished

finished quick design (in a total of 15 minutes together with the analysis)

comment:6 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 4

Very important task with good agenda.

4p (10m)

comment:7 Changed 10 years ago by boyan

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to boyan

starting implementation

comment:8 Changed 10 years ago by boyan

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Effort changed from 4 to 3

Implementation finished in about 3 eff. All base modules are cleaned up from failing and fake tests. Only two demos need to be refactored in order to be working.

comment:9 Changed 10 years ago by mira

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to mira

I restored some deleted test, it is commited in trunk in revision [3966]

comment:10 Changed 10 years ago by mira

  • Cc boyan added

It passes though PageUnitTest still fails. It has to be fixed.

comment:11 Changed 10 years ago by boyan

  • Cc boyan removed

was working on my machine, will be fixed at next iteration

comment:12 Changed 9 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.