Ticket #1746 (closed bug: worksforme)

Opened 11 years ago

Last modified 11 years ago

Tweak: Text performance is slow when there are no spaces in the text.

Reported by: vlado Owned by: vlado
Priority: major Milestone: M09_BETA1
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: vlado Design_owners: vlado
Imp._owners: vlado Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description (last modified by vlado) (diff)

There is a very big performance problem on texts with low number of spaces.

Change History

comment:1 Changed 11 years ago by vlado

  • Owner set to vlado
  • Status changed from new to s1a_analysis_started

comment:2 Changed 11 years ago by vlado

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 11 years ago by vlado

  • Design_owners set to vlado
  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Imp._owners set to vlado

Bug fixed on a separate branch branches/private/vlado/demo1-bugfix in [3917].

comment:4 Changed 11 years ago by vlado

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 follow-up: ↓ 11 Changed 11 years ago by vlado

  • Status changed from s2a_design_started to s2b_design_finished

comment:6 Changed 11 years ago by vlado

  • Status changed from s2b_design_finished to s2c_design_ok

comment:7 Changed 11 years ago by vlado

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:8 Changed 11 years ago by vlado

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:9 Changed 11 years ago by vlado

  • Description modified (diff)

comment:10 Changed 11 years ago by deyan

  • Priority changed from major to critical
  • Milestone set to M09_BETA1

fixing ticket

comment:11 in reply to: ↑ 5 Changed 11 years ago by vlado

  • Breaks.WORD_BREAK.getSeparationCharacters() changed
    • Exposed as public to be used in different parts of the project.
    • New separators added.
  • NaiveHotText changes restored from layout-perpormance-changes branch (wiped out in trunk after merging chaining and moving in the new impl package).
  • Concept of a manager mode added to AtomManager (exposed as size mode in LayoutBuilder) to represent the initial AtomManager that should be created in the beginning and when reset is called. The idea is first to initialize the most probable AtomManager, as its creation may be a performance problem.
  • LayoutBuilder.initializeSizeMode(HotText) and AtomManger.initializeManagerMode(HotText) added to analyse the text and set the new manager mode.
  • LayoutBuilderTest updated to check performance of strings with average number of separators and with no separators.

comment:12 Changed 11 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 3.5
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 3.5

The layout is slow as ever... but maybe faster, the analysis people should say their opinion here :)

Merged to the trunk in [3940].

3.5p (20m)

comment:13 Changed 11 years ago by dido

  • Priority changed from critical to major
  • Status changed from s3c_implementation_ok to new

It may be faster, but there is no significant change. Still typing more than 2 lines ends up with serious performance issues.

comment:14 Changed 11 years ago by dido

  • Status changed from new to s1c_analysis_ok

comment:15 Changed 11 years ago by deyan

  • Status changed from s1c_analysis_ok to closed
  • Total Hours set to 0
  • Add Hours to Ticket set to 0
  • Billable? set
  • Estimated Number of Hours set to 0
  • Resolution set to worksforme

fixed since redesign

Note: See TracTickets for help on using tickets.