GROUP_SCRIPTING_R0

[mitex]

GROUP_SCRIPTING_R0

Ticket	Summary	Effort	Status
#1179	SCRIPTING_INTERPRETER_R0	1.5	closed
#1183	SCRIPTING_MANIPULATION_R0	1.5	closed

[mitex]

analysis finished (1h)

[mitex]

Replying to mitex:
analysis finished (2h)

[dido]

The editing of scripts via Sophie should be included in this revision.

[deyan]

These two subrequirements overlap each other

• Add 'Insert Script File' button inside 'Insert' menu
• Create 'Insert Script' button inside 'Insert' menu that creates new resource.

The right one is Insert -> Script, because the word "file" is not met in the insert menu

• The choise of a scripting language is just mentioned in the implementation idea, I think this is very important for the overview of the task.
• The button that appears only when a script is selected, should be rethought - currently, the policy is to add inactive buttons insead of invisible.

[meddle]

Code related notes:

• Remove storage.debugPrint(0); from your code for review.
• Use AutoVisualProviders.
• Hmmm that's not good: ScriptResource resource = model().get().get(ScriptResource.class);, use the current book to get the script resource like ScriptResource resource = model().get().get(ScriptResource.class, CurrentBookUtil.getCurrentBook());
• Umm you use the create method of the ResourceProperty in strange way:

          @Override
          protected Object create() {
                  JPanel panel = swingComponent().get();
                 
                  JScrollPane scrollPane = new JScrollPane(textArea().get());
                  panel.add(scrollPane);
                 
                  JButton runButton = new LogicR3Button("Run", new EventR3(
                              ScriptDocumentWindow.this, null, null, null,
                              EventIds.RUN_SCRIPT));
                  panel.add(runButton);
                 
                  return new Object();
          }
  

  // RIGHT:
          @Override
          protected JPanel create() {
                  JPanel panel = swingComponent().get();
                 
                  JScrollPane scrollPane = new JScrollPane(textArea().get());
                  panel.add(scrollPane);
                 
                  JButton runButton = new LogicR3Button("Run", new EventR3(
                              ScriptDocumentWindow.this, null, null, null,
                              EventIds.RUN_SCRIPT));
                  panel.add(runButton);
                 
                  return panel;
          }
  

• Remove the System.out.printlns form the code for review.
• You added a new module, for the implementation review make sure that everything is OK. See Integration/CheckList.

Design notes:

• APPLY the analysis review comments to your analysis and work with them in mind!!!
• Where is your test that tests the scripting logic??? That is the most important test... The demo is good idea though.
• You know the script must be saveable with the book, so it's resource descriptor and js file must me storable the right way (see text resources persistence) in the R3.
• Rename EventIds to ScriptEventIds if they are a separate file.

3.5p (50m)

[meddle]

Hmmm...

• Some notes:
  • "if"s even one row must be with curly brackets
  • Bad spacing in some places.
  • The property book should be renamed to modelDocument and the AutoProperty with that name should be deleted.
  • The Persister of the script should persist it's scriptText using PropRef...
• And there is a serious improvement in your coding and coding style.

3.5p (3h)

[deyan]

Batch update from file query-obsoleted.csv