Ticket #1768 (closed unplanned_task: obsolete)

Opened 10 years ago

Last modified 9 years ago

GROUP_SCENES_R0

Reported by: gogov Owned by: gogov
Priority: major Milestone: M10_BETA2
Component: BASE_SCENE Version: 2.0
Keywords: scenes, sprites, tiles, java3d, gl Cc: deni, gogov
Category: BASE Effort:
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: deni, gogov Design_owners: deni, gogov
Imp._owners: deni, gogov Test_owners:
Analysis_reviewers: pap Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 4
Test_score: 0

Description (last modified by gogov) (diff)

Change History

comment:1 Changed 10 years ago by gogov

  • Description modified (diff)

comment:2 Changed 10 years ago by gogov

  • Owner set to gogov
  • Status changed from new to s1a_analysis_started

comment:3 Changed 10 years ago by gogov

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 10 years ago by deyan

  • Status changed from s1b_analysis_finished to new
  • Analysis_score changed from 0 to 2

You should provide some working prototype (code), it may not be working, but should have a schedule for the real optimisation.

comment:5 Changed 10 years ago by gogov

  • Keywords tiles, java3d, gl added; tiles removed
  • Status changed from new to s1a_analysis_started
  • Effort 6 deleted
  • Analysis_owners changed from gogov to deni, gogov

comment:6 Changed 10 years ago by gogov

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:7 Changed 10 years ago by pap

  • Cc deni, gogov added
  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to pap
  • Analysis_score changed from 2 to 3.5
  • Seems sensible to me
  • Please have in mind to include as a result some kind of schedule for the real implementation of these features in the following two weeks.
  • The later was already mentioned in the previous review.
  • The subtickets chosen are not very well chosen.
  • The worse thing is that #259 SCENE_COMMONS_R1 actually hides an implemented task, which was returned because of missing automatic tests.

comment:8 Changed 10 years ago by gogov

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:9 Changed 10 years ago by gogov

  • Status changed from s2a_design_started to s2b_design_finished

comment:10 Changed 10 years ago by gogov

  • Design_owners set to deni, gogov

comment:11 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle

I think the designs are OK, for me the main ideas were clear and I'm not a scenes guy, so that is good.

@deni

The code that you committed in your branch is not in the quality for the review and you know it, don't repeat that mistake. And this "Test" class... I was amazed....

@ gogov

Put the branch and some explanations about the your demo in the implementation section. Somethings like what were your problems and stuff... the things you told me...

3.5p (2h)

comment:12 Changed 10 years ago by gogov

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to deni, gogov

comment:13 Changed 10 years ago by gogov

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:14 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle

I think this source code is enough for the implementation of this task, the demos are running (slowly bu running, with some optimizations may be everything will be fine?) so

4p (30m)

comment:15 Changed 9 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.