TLID:913 Crash when trying to insert .jpg instead of pdf

[deyan]

1. Choose Insert -> PDF... Choose "All files (*.*)" from the dropdown menu.
2. Select "jpg logo sophie2.jpg" and click "Insert".
3. Click OK to close the dialog

1. A file dialog appears. Files of type dialog says"All files (*.*)" In the file browser folder and all files appear. When a folder is selected, instead of "Insert" an "Open" button with the same size appears.
2. A dialog "Unsupported file" appears
3. A file dialog appears. Files of type dialog says"All files (*.*)" In the file browser folder and all files appear.

Crash on step 2, attached log.

[mitex]

Implementation (patch)

[mitex]

The problem is that a RuntimeException is thrown from an auto property and the catch block waits for an IOException.

Solution:
In PDFResource.pdfFile do not throw an exception, instead write to the log and return null.
In PDFLogic, createPDFResource, show an error message if (pdfResource.pdfFile().get() == null) and then set pdfResource = null;

[meddle]

Mitex, I'm amassed again...

• I want branch, not patch, but this is small thing.
• Most importantly, it's important for every bug there MUST be a test that assure the bug will not pop again!
• You fixed that with Exception swallowing, I can't pass that implementation!

1p (30m, talked with some people about those kinds of bugs)

[george]

The problem is that "All Files" dropdown always active, allowing the user to skip file filters, thus allowing him to add an image as a pdf file or even an unsupported file.

Solution: "All files" dropdown in FileDialog is now removed. This is not enough however, user can type in the name of an existing resource file, for example an image, when inserting a pdf file, and the result will be the same as without the FileDialog modification. That is why another check is made - if the opened file is accepted by the chosen file filter, in the FileDialogInput. Changes can be seen here: FileDialog.

[meddle]

Failed with #1899