File insert: forbid inserting files of non-supported filetypes at least.

[deyan]

File insert: forbid inserting files of non-supported filetypes at least. Do not allow inserting avi instead of audio for example. This one is still present. This should be solved for all from->to cases!

[george]

The problem is the same as #1809. The only difference is that this bug refers to one more situation - inserting files that do not exist. Part 2. of the solution handles this situation.

• The problem is that "All Files" dropdown always active, allowing the user to skip file filters, thus allowing him to add an image as a pdf file or even an unsupported file.

Solution:

1. "All files" dropdown in FileDialog is now removed. This is not enough however, user can type in the name of an existing resource file, for example an image, when inserting a pdf file, and the result will be the same as without the FileDialog modification. That is why another check is made - if the opened file is accepted by the chosen file filter, in the FileDialogInput. Changes can be seen here: FileDialog.

2. Changes in all logics that import files are made. A check is made, if the file selected for importing exists. Changeset [5131].

[meddle]

• Do not remove "All files" item. Just add a check if the extension is proper, if not - bring a dialog "Unsupported image" "Unsupported book",... etc. Later a mimetype check may be implemented. This way the fix will make it to trunk. Otherwise good job.
• Code notes:
  • What is that strange check : pdfFile.exists() == true, just check pdfFile.exists() and if you want to check if something boolean is false, check !something
• Svn notes:
  • Don't commit the target directory!

Write your name as a analysis reviewer (you understood the bug) and implementation owner.

[george]

There is a better solution using MIME utils. With mime you can check the input file's type regardless about the file extension. Implementation for the idea: [5174], see code at FileDialog.java.