Ticket #1817 (closed unplanned_task: obsolete)

Opened 10 years ago

Last modified 10 years ago

IMMUTABLE_TREE_R0

Reported by: stefan Owned by: stefan
Priority: major Milestone: M10_BETA2
Component: BASE_PERSISTENCE Version: 2.0
Keywords: Cc:
Category: BASE Effort: 7
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: stefan Design_owners:
Imp._owners: Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: meddle, meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description (last modified by stefan) (diff)

wiki page: IMMUTABLE_TREE_R0

Change History

comment:1 Changed 10 years ago by stefan

  • Owner set to stefan
  • Status changed from new to s1a_analysis_started
  • Description modified (diff)

comment:2 Changed 10 years ago by stefan

  • Add Hours to Ticket set to 0
  • Estimated Number of Hours set to 0
  • Total Hours set to 0
  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Billable? set

comment:3 Changed 10 years ago by meddle

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 3
  • I think you should say in which branch you will work
  • The test cases are not a requirement they are always mandatory.
  • The list is for the requirements.
  • You have interface for the list, you should use it because in the big refactoring everybody is using it.

Take these things in mind for the design to pass :)

3p (10m)

comment:4 Changed 10 years ago by stefan

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 Changed 10 years ago by stefan

  • Status changed from s2a_design_started to s2b_design_finished

comment:6 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2
  • Design_reviewers set to meddle

So I'll fail the design:

  • I told you in the analysis review, you will have to use the current ImmList interface in the second_resource_refactoring branch for your list, because the whole model is using it.
  • You didn't give me design related code, you know the design code MUST be mergeable without compilation errors.
  • You didn't say in which branch you worked again...
  • About the tests:
    • So you have repeating code for checking the trees and operations, extract it in a test util class.
    • Use the SophieLogger to log in your tests, not System.out.println I know it's buggy, but when sending code for review you must use it.
    • Small thing, the second one is not necessary:
          assertEquals(list, tree.asList());
          assertEquals(tree.asList(), list);
      

2p (25m)

comment:7 Changed 10 years ago by stefan

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:8 Changed 10 years ago by stefan

  • Status changed from s2a_design_started to s2b_design_finished
  • Effort set to 7d

comment:9 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2 to 3.5
  • Design_reviewers changed from meddle to meddle, meddle

I think it passes, just fix your JavaDoc and pass it to the implementation review.

3.5p (1h)

comment:10 Changed 10 years ago by stefan

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:11 Changed 10 years ago by stefan

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:12 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to meddle

So, I think in some places the JavaDoc is not enough, for example you could explain some of the algorithms in it... but, your choice.
Another thing is that Rado's code was not exactly by the standards, but...

3.5p (70m)

comment:13 Changed 10 years ago by stefan

What is Rado's code? How it is not by the standards?
About the algorithm, I suppose you speak of Red-Black tree algorithm, which its widly available (for ex. http://wikipedia.org)...

comment:14 Changed 10 years ago by pap

  • Effort changed from 7d to 7

although the effort field is useles it should be a pure float without letters

comment:15 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.