Ticket #1819 (closed planned_task: obsolete)

Opened 10 years ago

Last modified 10 years ago

GROUP_MEM_RESOURCES_MODEL_R0

Reported by: mira Owned by: mira
Priority: blocker Milestone: M10_BETA2
Component: BASE_RESOURCE_MODEL Version: 2.0
Keywords: Cc:
Category: BASE Effort:
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: mira Design_owners: mira
Imp._owners: mira Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: kyli Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3 Imp._score: 3.5
Test_score: 0

Description (last modified by mira) (diff)

Change History

comment:1 Changed 10 years ago by mira

  • Owner set to mira
  • Status changed from new to s1a_analysis_started
  • Description modified (diff)
  • Analysis_owners set to mira

comment:2 Changed 10 years ago by mira

  • Description modified (diff)

comment:3 Changed 10 years ago by mira

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 10 years ago by meddle

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 3.5

I have no special notes, accept that I'm not sure whether the name of this task should be GROUP_ or UNPLANED_, because we don't group anything, but may be we are doing all the things acquired for the memory access to work at once... I don't know, you should think about that.

3.5p (10m)

comment:5 Changed 10 years ago by meddle

  • Design_owners set to mira
  • Owner changed from mira to meddle
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:6 Changed 10 years ago by mira

  • Status changed from s2a_design_started to s2b_design_finished

Finishing the design.

comment:7 Changed 10 years ago by kyli

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3
  • Design_reviewers set to kyli
  • The type of the ticket is bug - I don't get it.. I also agree with meddle that this is not a group.
  • "It does not memorize the created and creates new ones every time when opening an ref but since the inner accesses don`t have model." - I don't understand the idea here..
  • Some phrases in the design were really hard for me to translate..
  • You have not linked tests, you have linked a huge changeset. Couldn't you at least specify concrete names?
  • Some of the tests I looked at conained "TODO" with an empty block, I think this is not a good idea.

comment:8 Changed 10 years ago by mira

  • Owner changed from meddle to mira
  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to mira
  • Type changed from bug to planned_task

I changed the type of the ticket. I don`t know how it became a 'bug'.

I reviewed the text of the design page and filled in some things to make it clearer.

There is always more to do for testing and it is good to mark that but for now I think that provided tests are enought.

comment:9 Changed 10 years ago by mira

  • Status changed from s3a_implementation_started to s3b_implementation_finished

The implementation should not be merged into the trunk at this point. The provided changeset are just for review purposes. It would be better for this logic to be merged with the review of GROUP_BOOK_MODEL_REDESIGN_R1.

comment:10 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to meddle

I have no comments you don't know. In the RootMemAccess you created a TopMemAccess that has options always null... That's bad. And you have strange inconsistent way of commenting JavaDoc. Sometimes you write '-' before your comments, sometimes not... Don't copy-paste so much and write JavaDoc when adding new methods and classes. In the end I am very happy with your work.

3.5p (25m)

comment:11 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.