Ticket #1868 (closed bug: fixed)

Opened 12 years ago

Last modified 11 years ago

Empty book titles should not be allowed

Reported by: deyan Owned by: diana
Priority: major Milestone: M11_BETA3
Component: uncategorized Version: 2.0
Keywords: Cc: diana
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: diana
Imp._owners: diana Test_owners:
Analysis_reviewers: diana Changelog:
Design_reviewers: meddle, todor Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description

Creating a new book with no title is possible and creates a tiny button in the tabbar.

Change History

comment:1 Changed 12 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 12 years ago by diana

  • Design_owners set to diana
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Imp._owners set to diana

In BookPropertiesDialog in actionPerformed method of the okButton add check if the length of the title is zero. If so the dialog is not closed and an error message is shown.
source code: [5147]

comment:3 Changed 12 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

comment:4 Changed 12 years ago by diana

  • Status changed from s2b_design_finished to s2c_design_ok

comment:5 Changed 12 years ago by diana

  • Owner set to diana
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:6 Changed 12 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:7 Changed 12 years ago by deyan

No sure if it is a result of this fix but when you delete title and click ok a "not correct title" appears. Then you add some letters and delete page width, click OK. Ok stays pressed as long as the cursor is over it and the "Not correct title" does not change to "Not correct width".

comment:8 Changed 12 years ago by diana

source code: [5164]

comment:9 Changed 12 years ago by diana

source code: [5176]

comment:10 Changed 12 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to diana
  • Analysis_score changed from 0 to 3.5
  • Imp._reviewers set to meddle, todor
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle, todor
  • Imp._score changed from 0 to 3.5

Merged in [5185].

comment:11 Changed 11 years ago by dido

  • Status changed from s3c_implementation_ok to s1c_analysis_ok

needs to be fixed in the new branch

comment:12 Changed 11 years ago by diana

  • Status changed from s1c_analysis_ok to s2a_design_started

In BookPropertiesDialog in actionPerformed method of the okButton add check if the length of the title is zero. If so the dialog is not closed and an error message is shown.
source code:[6303]

comment:13 Changed 11 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

comment:14 Changed 11 years ago by diana

  • Status changed from s2b_design_finished to s2c_design_ok

comment:15 Changed 11 years ago by diana

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:16 Changed 11 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:17 Changed 11 years ago by meddle

  • Cc diana added
  • Status changed from s3b_implementation_finished to s3c_implementation_ok

Works for me... But you can change the title/size of the desktop book, could you fix that?

comment:18 Changed 11 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to fixed

Book with " " for a title is possible, not sure if it is the right behaviour.

Note: See TracTickets for help on using tickets.