Ticket #1880 (closed bug: fixed)

Opened 12 years ago

Last modified 11 years ago

Crash: Invalid links (for example 'Toggle frame' and no frame specified) crash.

Reported by: deyan Owned by: nenko
Priority: major Milestone: M11_BETA3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: nenko
Imp._owners: nenko Test_owners:
Analysis_reviewers: nenko Changelog:
Design_reviewers: meddle, todor Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 3
Design_score: 3 Imp._score: 3
Test_score: 0

Description

Invalid links (for example 'Toggle frame' and no frame specified) crash.

Change History

comment:1 Changed 12 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 12 years ago by nenko

  • Design_owners set to nenko
  • Status changed from s1b_analysis_finished to s2a_design_started

comment:3 Changed 12 years ago by nenko

  • Status changed from s2a_design_started to s2b_design_finished

This is NullPointerException because a check is not made. Also there's code duplication

comment:4 Changed 12 years ago by nenko

  • Status changed from s2b_design_finished to s2c_design_ok

comment:5 Changed 12 years ago by nenko

  • Owner set to nenko
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:6 Changed 12 years ago by nenko

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Duplicated code is now in one method and a check for null is added
[5167]

comment:7 Changed 12 years ago by nenko

  • Imp._owners set to nenko

comment:8 Changed 12 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to nenko
  • Analysis_score changed from 0 to 3
  • Imp._reviewers set to meddle, todor
  • Design_score changed from 0 to 3
  • Design_reviewers set to meddle, todor
  • Imp._score changed from 0 to 3

Already in the branch.

comment:9 Changed 11 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to fixed

links without target are now saved and there are no crashes

Note: See TracTickets for help on using tickets.