Ticket #1926 (closed unplanned_task: obsolete)

Opened 12 years ago

Last modified 11 years ago

UNPLANNED_LOGIC_REFACTORING_R0

Reported by: mitex Owned by: boyan
Priority: critical Milestone: M11_BETA3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: mitex,boyan Design_owners: mitex,boyan
Imp._owners: mitex,boyan,jani Test_owners:
Analysis_reviewers: mira, dido Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 4
Design_score: 4.5 Imp._score: 4
Test_score: 0

Description

Change History

comment:1 Changed 12 years ago by mitex

  • Status changed from new to s1a_analysis_started

comment:2 Changed 12 years ago by mitex

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 12 years ago by mira

  • Status changed from s1b_analysis_finished to new
  • Analysis_reviewers set to mira
  • Analysis_score changed from 0 to 2

I think that the task scope is larger. Some of the task requirements are too concrete and should be made as design decisions. Example for those are the concrete naming conventions of the operation enums and where to move the logics.

According to me the analysis should look like this:

All logics should be rafactored to:

  • Use the LogicR3 event handling instead direct methods invocation.
  • Use the new accesses registering a single ModelChange with the appropriate effect and description.
  • All buttons should fire events instead of using clicked method.
  • While refactoring should be fixed code smells like code dublication, naming inconsistency, etc.

comment:4 Changed 12 years ago by boyan

  • Owner changed from mitex to boyan
  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from mitex to mitex,boyan
  • Milestone set to M11_BETA3

taking the task for analysis

comment:5 Changed 12 years ago by boyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

analysis finished

comment:6 Changed 12 years ago by dido

  • Status changed from s1b_analysis_finished to new
  • Analysis_reviewers changed from mira to mira, dido
  • The task scope is bigger.
  • Please read and include the previous comments in requirements section
  • The main goal is to make all controllers to use LogicR3
  • In how to demo section please find a way to demonstrate this no matter is not visible for the end user. For example you could use test or something else.

Analysis Reviewed 2p (40m)

comment:7 Changed 12 years ago by dido

  • Cc dido, mira, boyan added

comment:8 Changed 12 years ago by boyan

  • Status changed from new to s1a_analysis_started

taking for re-analysis

comment:9 Changed 12 years ago by boyan

  • Priority changed from major to critical
  • Status changed from s1a_analysis_started to s1b_analysis_finished

finishing it for the second time, included the things mentioned.

comment:10 Changed 12 years ago by boyan

  • Cc boyan removed

removing cc

comment:11 Changed 12 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 2 to 4

Analysis Reviewed 4p (10m)

comment:12 Changed 12 years ago by boyan

  • Design_owners changed from mitex to mitex,boyan
  • Status changed from s1c_analysis_ok to s2a_design_started

starting design

comment:13 Changed 12 years ago by boyan

  • Status changed from s2a_design_started to s2b_design_finished
  • Imp._owners changed from mitex to mitex,boyan, jani

finished design

comment:14 Changed 12 years ago by boyan

  • Cc meddle added; dido, mira removed

changing cc

comment:15 Changed 12 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 4.5
  • Design_reviewers set to meddle

I think the design couldn't be more clear :)

4.5p (70m)

comment:16 Changed 12 years ago by boyan

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners changed from mitex,boyan, jani to mitex,boyan,jani

starting implementation

comment:17 Changed 12 years ago by meddle

  • Cc meddle removed

comment:18 Changed 11 years ago by boyan

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Done, although still a lot of things are left for next iterations (see comment in implementation section).

comment:19 Changed 11 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle

I think it's OK.. It's better to compare constants with variables i the way in which the constant calls the 'equals' method...

4p (45m)

comment:20 Changed 11 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.