Ticket #1927 (closed bug: fixed)

Opened 10 years ago

Last modified 10 years ago

tweak: saved color from border color picker do not appear in fill color picker

Reported by: danvisel Owned by:
Priority: minor Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: danvisel Design_owners: nenko
Imp._owners: nenko Test_owners: vanya
Analysis_reviewers: nenko Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3.5
Test_score: 5

Description

  1. Open Sophie.
  2. Make a new book.
  3. Open the page border & fill HUD.
  4. Click on the border color square to open the color picker HUD.
  5. Select a color at random.
  6. Click "Save" to save the color.
  7. Click on the border color square to close the color picker HUD.
  8. Click on the fill color square to open the color picker HUD.

On 6, the color picked is saved as the first saved color.
On 8, no saved colors are apparent when the fill color picker is opened.

It seems that saved border colors and saved fill colors are separate; these should be the same (user might want to use the same color for the fill of one frame as the border on another frame.)

Change History

comment:1 Changed 10 years ago by danvisel

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by vanya

  • Milestone changed from M09_BETA1 to M12_RELEASE

comment:3 Changed 10 years ago by nenko

  • Design_owners set to nenko
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Analysis_reviewers set to nenko
  • Analysis_score changed from 0 to 3.5

comment:4 Changed 10 years ago by nenko

  • Imp._owners set to nenko

This happens because every instance of ColorPicker HUD has its own container for colors. The fixes add s single container (new singleton class) that is used instead the old one.

Changeset: [7656]

comment:5 Changed 10 years ago by nenko

  • Status changed from s2a_design_started to s3b_implementation_finished

comment:6 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to meddle, todor

Merged to the trunk at [7669]. Don't comment old code, just delete it...

3.5p (30m)

comment:7 Changed 10 years ago by vanya

  • Status changed from s3c_implementation_ok to closed
  • Test_owners set to vanya
  • Resolution set to fixed
  • Test_score changed from 0 to 5
Note: See TracTickets for help on using tickets.