Ticket #1931 (closed unplanned_task: obsolete)

Opened 12 years ago

Last modified 11 years ago

MEDIA_ENGINE_IMPL_MAIN_R3

Reported by: stefan Owned by: stefan
Priority: major Milestone: M11_BETA3
Component: MEDIA_CONTENT Version: 2.0
Keywords: media engine Cc: stefan, nenko, izomorphius, sveto, milo
Category: MAIN Effort: 1
Importance: 0 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: stefan Design_owners: stefan
Imp._owners: Test_owners:
Analysis_reviewers: dido Changelog:
Design_reviewers: pap, meddle Imp._reviewers:
Test_reviewers: Analysis_score: 3.5
Design_score: 1 Imp._score: 0
Test_score: 0

Description (last modified by stefan) (diff)

Change History

comment:1 Changed 12 years ago by stefan

  • Owner set to stefan
  • Status changed from new to s1a_analysis_started

comment:2 Changed 12 years ago by stefan

  • Description modified (diff)

comment:3 Changed 12 years ago by stefan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 12 years ago by dido

  • Status changed from s1b_analysis_finished to new
  • Analysis_reviewers set to dido
  • Analysis_score changed from 0 to 2
  • Custom fields in this ticket are empty, please fill them
  • How to demo section is empty, please fill it in order to continue with this task, the rest seems fine

Analysis Reviewed 2p (10m)

comment:5 Changed 12 years ago by stefan

  • Category changed from unknown to MAIN
  • Importance set to 0
  • Effort set to 1

comment:6 Changed 12 years ago by stefan

  • Status changed from new to s1a_analysis_started
  • Analysis_owners set to stefan

comment:7 Changed 12 years ago by stefan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:8 Changed 12 years ago by stefan

  • Keywords media engine added

comment:9 Changed 12 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 2 to 3.5

Analysis Reviewed 3.5p (10m)

comment:10 Changed 12 years ago by stefan

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:11 Changed 12 years ago by stefan

  • Status changed from s2a_design_started to s2b_design_finished

comment:12 Changed 12 years ago by stefan

  • Design_owners set to stefan

comment:13 Changed 12 years ago by pap

  • Cc stefan, nenko, izomorphius, sveto, milo added
  • Design_score changed from 0 to 1
  • Design_reviewers set to pap, meddle
  • Status changed from s2b_design_finished to s1c_analysis_ok
  • You rely on some other task that is not yet implemented. Even more it is the previous revision of this task that is still de_st with no design at all in the wiki page.
  • Actually it almsot seems as you are trying to silently pass MEDIA_ENGINE_IMPL_MAIN_R2.
  • I don't understand why do you work so asynchronously.
  • The design says absolutely nothing about the Java part of the task.
  • Nothing is said for the communication protocol specified in the requirements section.
  • It would be nice to mention your revisions with the design related code and not just a branch used by several people.
  • I don't like the approach where you allocate memory in a method(by using new) and then returning the pointer and leaving the caller to free it.(SaveAudioBuffer)
  • There is no documentation in your code. This is a serious problem. First it is much easier to document things when you create them and second documented design code is easier to understand by reviewers.
  • Also it is quite good to have more code to prove your desing,
  • AudioPlayer.cpp -> Sophie2MediaContext: it would be better to put every member in a differen row. Try to write more readable and less error-prone code. C++ is not so different from Java regarding code readability.
  • Same with the members of Decoder/AudioPlayer.
  • I don't understand why have you put a static modifier to the methods in AudioPlayer.cpp regarding Sophie2 Media Protocol.
  • I dont see any description of these methods in the wiki page.
  • I find it strange to have both is_open and is_close member variables in the Decoder class.
  • I think it would be very nice to use C++ namespaces as we use packages in Java
  • The native team should really make some standard for writing C++ code so that we can check it. For example I don't like the under_score convention.
  • For example the protocol part in the design may look like in http://sophie2.org/trac/wiki/FLASH_CONTENT_BASIC_R2 .

comment:14 Changed 11 years ago by deyan

  • Status changed from s1c_analysis_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.