HOT_TEXT_REDESIGN_R1

[vlado]

Continue redesign to stabilize text internals, fix bugs and clarify the usage of the new text from the client code.

HOT_TEXT_REDESIGN_R1

[meddle]

• I don't like the priorities... If you have the priority one things for this week => the priority 3 things (the resource integration) will be after three weeks... But the Beta is exactly after 3 weeks, we can not lose time, we must integrate the text with the new resources => to be usable by the Sophie 2 application with Priority 2.
• The OutOfMemory problem must be with Priority 1.
• "Move(pull up) model functionality from SimpleSwingTextView to the abstract SwingTextView "; Model functionality in view?? I don't understand this sentence. Soo the documentation can be posponed with Priority 2, and the resource integration too, and the profiling/fixing OutOfMemory problems are with Priority 1.

2p (15m)

[meddle]

OK this is a good strategy :) If you implement it in time we will have a good Beta with text

4.5p (10m)

[meddle]

• Instead of introducing the "smart" package you could just remove everything old and replace it with the new implementation
• I don't understand the purpose of the "mvc" package and this is quite a bad name
• I think that memory usage should be measured at design phase and places for optimisation should be proposed in the design.
• I am a bit sad that the text is so slowly documented
• And in the tests, I think I like them for now but assertEquals have a special arguments -> first expected, than actual, not like in yours assertEquals(secondLine.getEnd(), text.advance(thirdLine.getBegin(), -1));
• More test will be needed for highlighting, selection and etc...But now is important a performance test with profiler to be included, Milo's demo is something like that.
• All the test must pass for the implementation.

3.5p (70m)

[meddle]

So... I don't think I can review all of this good, I god some idea how the things work, I had troubles with the missing documentation an have some trivial comments:

• When you use making a immutable tree list from java.util.List so often why don't just write a factory method to the list for that?
• In the TextView you had to rename the Ops to the EventIds... See the logic refactoring.
• Don't write fake JavaDoc, no JavaDoc is better than fake JavaDoc, because it's easy to detect and document. The fake one hides warnings.
• Remane stuff like the 'FLOW_MOUSE_OPERATION' in the logic to 'ON_FLOW_MOUSE'... In the logic task the implementors introdiced some rules for writing logics.
• Fix the auto-generated equals methods to be according to our standarts.
• I don't know if it's good to use the old dnd login in the text, because Tanya is working on the dnd rask and you will have conflicts in all possible ways...

3.5p (140m)

[deyan]

Batch update from file query-10.csv