Ticket #1930 (closed unplanned_task)

Opened 9 years ago

Last modified 9 years ago

HOT_TEXT_REDESIGN_R1

Reported by: vlado Owned by: vlado
Priority: critical Milestone: M09_BETA1
Component: TEXT_FLOWING Version: 2.0
Keywords: Cc:
Category: BASE Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: vlado, diana, vlado, diana Design_owners: vlado, diana
Imp._owners: vlado, diana Test_owners:
Analysis_reviewers: dido, meddle, meddle Changelog:
Design_reviewers: meddle, pap Imp._reviewers: meddle
Test_reviewers: Analysis_score: 4.5
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description (last modified by vlado) (diff)

Continue redesign to stabilize text internals, fix bugs and clarify the usage of the new text from the client code.

HOT_TEXT_REDESIGN_R1

Change History

comment:1 Changed 9 years ago by vlado

  • Owner set to vlado
  • Status changed from new to s1a_analysis_started
  • Description modified (diff)

comment:2 Changed 9 years ago by vlado

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 9 years ago by vlado

  • Summary changed from Next revision of the text redesign task to HOT_TEXT_REDESIGN_R1

comment:4 Changed 9 years ago by dido

  • Analysis_reviewers set to dido

comment:5 Changed 9 years ago by meddle

  • Status changed from s1b_analysis_finished to new
  • Analysis_reviewers changed from dido to dido, meddle
  • Analysis_score changed from 0 to 2
  • I don't like the priorities... If you have the priority one things for this week => the priority 3 things (the resource integration) will be after three weeks... But the Beta is exactly after 3 weeks, we can not lose time, we must integrate the text with the new resources => to be usable by the Sophie 2 application with Priority 2.
  • The OutOfMemory problem must be with Priority 1.
  • "Move(pull up) model functionality from SimpleSwingTextView to the abstract SwingTextView "; Model functionality in view?? I don't understand this sentence. Soo the documentation can be posponed with Priority 2, and the resource integration too, and the profiling/fixing OutOfMemory problems are with Priority 1.

2p (15m)

comment:6 Changed 9 years ago by vlado

  • Status changed from new to s1a_analysis_started
  • Analysis_owners changed from vlado, diana to vlado, diana, vlado, diana

comment:7 Changed 9 years ago by vlado

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:8 Changed 9 years ago by meddle

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers changed from dido, meddle to dido, meddle, meddle
  • Analysis_score changed from 2 to 4.5

OK this is a good strategy :) If you implement it in time we will have a good Beta with text

4.5p (10m)

comment:9 Changed 9 years ago by vlado

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:10 Changed 9 years ago by vlado

  • Design_owners set to vlado, diana
  • Status changed from s2a_design_started to s2b_design_finished

comment:11 Changed 9 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle, pap
  • Instead of introducing the "smart" package you could just remove everything old and replace it with the new implementation
  • I don't understand the purpose of the "mvc" package and this is quite a bad name
  • I think that memory usage should be measured at design phase and places for optimisation should be proposed in the design.
  • I am a bit sad that the text is so slowly documented
  • And in the tests, I think I like them for now but assertEquals have a special arguments -> first expected, than actual, not like in yours assertEquals(secondLine.getEnd(), text.advance(thirdLine.getBegin(), -1));
  • More test will be needed for highlighting, selection and etc...But now is important a performance test with profiler to be included, Milo's demo is something like that.
  • All the test must pass for the implementation.

3.5p (70m)

comment:12 Changed 9 years ago by vlado

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to vlado, diana

comment:13 Changed 9 years ago by vlado

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:14 Changed 9 years ago by meddle

  • Cc vlado, diana added
  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to meddle

So... I don't think I can review all of this good, I god some idea how the things work, I had troubles with the missing documentation an have some trivial comments:

  • When you use making a immutable tree list from java.util.List so often why don't just write a factory method to the list for that?
  • In the TextView you had to rename the Ops to the EventIds... See the logic refactoring.
  • Don't write fake JavaDoc, no JavaDoc is better than fake JavaDoc, because it's easy to detect and document. The fake one hides warnings.
  • Remane stuff like the 'FLOW_MOUSE_OPERATION' in the logic to 'ON_FLOW_MOUSE'... In the logic task the implementors introdiced some rules for writing logics.
  • Fix the auto-generated equals methods to be according to our standarts.
  • I don't know if it's good to use the old dnd login in the text, because Tanya is working on the dnd rask and you will have conflicts in all possible ways...

3.5p (140m)

comment:15 Changed 9 years ago by vlado

  • Cc vlado, diana removed

comment:16 Changed 9 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.