ELEMENT_VIEWS_REDESIGN_R0

[deni]

ELEMENT_VIEWS_REDESIGN_R0

[meddle]

I think the analysis pass... But the demo is the most important thing! It is a requirement for this task to pass!

3p (10m)

[deyan]

Moving wiki page and renaming ticket

[pap]

• TODO(R4)s in FrameView - look at them and fix them
• FrameView.makeContentElement - Consider the state whre a frame has no content (getModel().getResourceKind().equals(FrameR4.KIND) ).
• Be sure to fix the warnings in the classes you edit.
• Use FrameResizeTest to fix frame resizing
• Rewrite the PageWorkAreaTest
• Why don't you put the different AlignElementButtons as static classes in the AlignElementsHud :)
• Write JaavDoc to every new method you write, please.
• Write JavaDoc to the undocumented methods in AppHaloUtil and find a better place for some of them.
• It would be nice to check for null values if you expect them or assert if not (GroupHalosLogic.ON_ENTER_GROUP).
• Write JavaDoc for ScopeRel elements.
• Probably it is better to write several Operations that have different filters instead of one having an instanceof check. (ElementLogic)
• You have repeating bad code ont the halo's compute visible
  • Bad code:

     	List<ElementView> selected = pwa.getSel().getSelected(); 
    	return ((selected.size() == 1 && selected.get(0) instanceof FrameView)  || selected.size() == 0); 
    

  • Better code :

    	return pwa.getSingleSelected(FrameView.class) != null || pwa.getSel().getSelected() == 0;
    

  • And because you use this check often the best thing is to have method for it, I know that that thing is applied for the page's and frame's common halos.
• In the annotation's palette use a tracking list to generate your items, not composing, because it's more optimal.
• Don't use " @SuppressWarnings("hiding")". Fix such problems other way.(BookViewOptions)
• Use braces even in single-lined for and if statements. Don't forget that in auto-generated equals method (BookViewOptions).
• Fake JavaDoc in SelectionRel.
• I heard that there is some kind of a convention for logis that states their members should have names starting with "ON_". (ScenePageLogic) - and you have warnings in this file.
• Exception swallowing in BackgroundImageField.ON_IMAGE_SUBMIT - throw a RuntimeException instead. Same with BackgroundPatternField.
• In most cases it is better to delete old code instead of commenting it out.
• Good luck :)

[meddle]

• Notes
  • The Shift key is used for selectiong not the Control
  • Don't write AutoActions in another anonimous extended classes if the parameters of the actions are in the main class. The sun compilator doesn't like that. Example:

    class Some {
    
        public void someMethod(0 {
            final int someParam = some_expression;
    	new Something() {
                private void methodA() {
                    new AutoAction("Some desc", true) {
                        public void performAuto() {
                            getChanger().setRaw(someKey, someParam);
                        }.register(some_where);
                    }
                }
            };
        }
    
    }
    
    

  • In the AutoActions why use ResourceChanger variables when getting sub changers instead SubResourceChanger ones.
  • I don't know if the selection order must be the order in the group. I think you should keep the Z-order after grouping.

3.5p (70m)

[deyan]

Batch update from file query-10.csv