Ticket #1939 (closed unplanned_task: obsolete)

Opened 12 years ago

Last modified 11 years ago

UNPLANNED_SCRIPTING_REFACTORING_R0

Reported by: mitex Owned by: mitex
Priority: major Milestone: M11_BETA3
Component: uncategorized Version: 2.0
Keywords: scripting, javascript, refactoring, new model Cc:
Category: EXTRA Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: mitex Design_owners: mitex
Imp._owners: mitex Test_owners:
Analysis_reviewers: meddle, pap Changelog:
Design_reviewers: pap, meddle Imp._reviewers: meddle, pap
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 4
Test_score: 0

Change History

comment:1 Changed 12 years ago by mitex

  • Status changed from new to s1a_analysis_started
  • Summary changed from UNPLANNED_SCRIPTING_REFACTORING to UNPLANNED_SCRIPTING_REFACTORING_R0

comment:2 Changed 12 years ago by mitex

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 12 years ago by meddle

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to meddle, pap
  • Analysis_score changed from 0 to 4

So I think the z-order is mandatory... but that is only my opinion ~meddle

4p (10m)

comment:4 Changed 12 years ago by mitex

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 Changed 11 years ago by mitex

  • Status changed from s2a_design_started to s2b_design_finished

comment:6 Changed 11 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to pap, meddle
  • Make a static method for creating new books (probably in BookDocView).
  • Use BookH.getIndexOf instead of writing that logic yourself.
  • Instead of removing a frame in your code write a method in ElementH that removes some of its children and use it.
  • Rename jsFunction_removeFrame to jsFunction_removeElement.
  • You can add a key holding a ResourceRef to the container book of the script in the ScriptResourceR4 class to solve the problem with finding the BookView for this script... Other approach is the ScriptView to contain it's container's BookView, but I think the first is better. If you don't have container book your ref will be the default value of your new key : ResourceRefR4.NONE_REF;

4p (1h)

comment:7 Changed 11 years ago by mitex

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:8 Changed 11 years ago by mitex

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:9 Changed 11 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle, pap

Soo we like the implementation but:

  • You had some malformed JavaDoc.
  • You had one significant action in your jsFrame (z order)
  • The empty frame is not a good choice, we change that logic to insert text frame.

4p (210m)

comment:10 Changed 11 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.