Ticket #1944 (closed unplanned_task)

Opened 10 years ago

Last modified 9 years ago

GROUP_TEMPLATES_R3

Reported by: deyan Owned by: jani
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: feedback Cc: jani
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan, jani Design_owners: jani, jani
Imp._owners: jani Test_owners:
Analysis_reviewers: todor Changelog:
Design_reviewers: meddle, meddle Imp._reviewers: meddle, pap, todor, deyan
Test_reviewers: Analysis_score: 4.5
Design_score: 4 Imp._score: 3.5
Test_score: 0

Change History

comment:1 Changed 10 years ago by deyan

  • Type changed from bug to unplanned_task

comment:2 Changed 10 years ago by deyan

  • Owner set to deyan
  • Status changed from new to s1a_analysis_started
  • Analysis_owners set to deyan, jani

comment:3 Changed 10 years ago by deyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 10 years ago by todor

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to todor
  • Analysis_score changed from 0 to 4.5

Very good analysis, with clear examples and ideas.

comment:5 Changed 10 years ago by jani

  • Design_owners set to jani
  • Owner changed from deyan to jani
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:6 Changed 10 years ago by jani

  • Status changed from s2a_design_started to s2b_design_finished

comment:7 Changed 10 years ago by deyan

  • Keywords feedback added

comment:8 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2.5
  • Design_reviewers set to meddle

Good ideas but I have the following questions/thoughts.

  • Why ResourceH does not have method that do the stuff with getting all the template keys in it. If there is no such method you can write one there, so you could call frameH.getTemplatedKeys();.
  • I'm concerned... I don't know if the transitive templating works, I mean f -> f' -> f'' templating for example... you should write tests about that.
  • You didn't describe the process of applying these templates and this changing of modes. The mode is calculated automatically, so how you will change it? You will change the TemplatedKey or you will set custom values? And when applying a template to a resource, you will set the untemplated templatable values by hand to not get the defaults from the template or?
  • You don't have tests for these situations and that's the reason this design is not complete...
  • And a note about the analysis from me... You mean HUD, not dialog :)

2.5p (1h)

comment:9 Changed 10 years ago by deyan

You mean HUD, not dialog :)

I mean dialog, not HUD

comment:10 Changed 10 years ago by deyan

Users are confused with the way templates work.

  • "The two small blue buttons with a pencil tip and a plus sign had no apparent effect on what I was doing."
  • "I was able to make a Sticky and type in it, but it would be nice to be able to double-click on the Sticky to edit text rather than clicking outside the box and clicking on the pen tool."
  • "Then the book extra and library tab were a little tough to figure out."

comment:11 Changed 10 years ago by jani

  • Design_owners changed from jani to jani, jani
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:12 Changed 10 years ago by jani

  • Status changed from s2a_design_started to s2b_design_finished

Notes taking into account. The f -> f' -> f" should work and is demonstrated in the integration test.

comment:13 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2.5 to 4
  • Design_reviewers changed from meddle to meddle, meddle
  • Notes:
    • When we integrated the embedded books all the refs given by the access are absolute... Update with the trunk and change your code. That refactoring will help the templating a lot. That is important.

I think now the design is clear for me so:

4p (20m)

comment:14 Changed 10 years ago by meddle

  • Cc jani added

comment:15 Changed 10 years ago by jani

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to jani

comment:16 Changed 9 years ago by jani

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:17 Changed 9 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to meddle, pap, todor, deyan

It passes :

  • The swing dialog in your dialog could be instantiated only one time.
  • Please fix all known issues.
  • Don't put spaces in the resource's names, it could be dangerous...

3.5p (150m)

comment:18 Changed 9 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.