Ticket #1982 (closed bug)
Save confirmations will be better than close confirmations
| Reported by: | deyan | Owned by: | mira |
|---|---|---|---|
| Priority: | critical | Milestone: | M12_RELEASE |
| Component: | uncategorized | Version: | 2.0 |
| Keywords: | Cc: | ||
| Category: | unknown | Effort: | |
| Importance: | Ticket_group: | ||
| Estimated Number of Hours: | 0 | Add Hours to Ticket: | 0 |
| Billable?: | yes | Total Hours: | 0 |
| Analysis_owners: | deyan | Design_owners: | mitex, mira |
| Imp._owners: | mitex, mira | Test_owners: | |
| Analysis_reviewers: | mitex, mira | Changelog: | |
| Design_reviewers: | meddle | Imp._reviewers: | meddle, todor |
| Test_reviewers: | Analysis_score: | 3.5 | |
| Design_score: | 3.5 | Imp._score: | 3.5 |
| Test_score: | 0 |
Change History
comment:3 Changed 16 years ago by deyan
- Priority changed from major to critical
- Summary changed from Save confirmations will be better that close confirmations to Save confirmations will be better than close confirmations
See #1896. Moving this as critical since it is very annoying
comment:4 Changed 15 years ago by mitex
- Design_owners set to mitex
- Status changed from s1b_analysis_finished to s2a_design_started
- Imp._owners set to mitex
comment:5 Changed 15 years ago by mira
- Design_owners changed from mitex to mitex, mira
- Status changed from s2a_design_started to s2b_design_finished
- Imp._owners changed from mitex to mitex, mira
The SyncOptions and SyncInfo of StoredResourceAccess should be used:
- The initial revision ids for last save and last sync should be set to initila revision and them changed when saving and syncronizing from server.
- Remove the additional field in MasterServerAccess used to remember the last sync revision and make it work with the SyncInfo.
- Also make it get its sync interval from the SyncOptions.
When saving a MasterFileAccess change the last saved revision id in its SyncInfo.
Create a method boolean shouldWarnOnClose() in DocView that checks if the document is modified and the user should be warned on closing.
In MainWindowLogic.ON_CLOSE iterate over all open documents and fire the CLOSE event for each of them. If the list of open windows is empty, close the application.
In DocumentsLogic.ON_CLOSE check if the value of DocView.shouldWarnOnClose}}} and if it is true, ask the user "... Do you want to save the changes?" (Y/N/Cancel). If the answer is Yes, call the utility method that saves the book.
Implement the shouldWarnOnClose() method for BookDocView :
- If in preview mode return false.
- If the head is the initial revision return false.
- If the head revision is the last sync revision return false.
- otherwise return true.
comment:8 Changed 15 years ago by mira
- Owner set to mira
- Status changed from s2c_design_ok to s3a_implementation_started
comment:9 Changed 15 years ago by mira
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:10 Changed 15 years ago by mira
All related code is in [branches/private/mira/bug1982]
comment:11 Changed 15 years ago by meddle
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Analysis_reviewers set to mitex, mira
- Analysis_score changed from 0 to 3.5
- Imp._reviewers set to meddle, todor
- Design_score changed from 0 to 3.5
- Design_reviewers set to meddle
- Imp._score changed from 0 to 3.5
Merged to the trunk at [7578]... good work, but I don't like your hyphenation and the server work took our time...
3.5p (1h)
comment:12 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
Batch update from file query-10.csv
