Ticket #1985 (closed bug: obsolete)

Opened 10 years ago

Last modified 8 years ago

Text caret should not be shown in preview mode and reader

Reported by: deyan Owned by: diana
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: feedback Cc: diana
Category: unknown Effort:
Importance: 60 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: diana
Imp._owners: diana Test_owners:
Analysis_reviewers: diana Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 2
Design_score: 2 Imp._score: 2.5
Test_score: 0

Description (last modified by deyan) (diff)

Do not show text cursor in preview mode, selection should be possible, but text cursors should not be shown. A text cursor should only be shown in a text frame when the frame is active (in author mode). See attached screenshot

Attachments

Screenshot-7.png (108.0 KB) - added by deyan 10 years ago.

Change History

Changed 10 years ago by deyan

comment:1 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by deyan

  • Description modified (diff)

comment:3 Changed 10 years ago by deyan

  • Description modified (diff)

comment:4 Changed 10 years ago by deyan

  • Keywords feedback added

comment:5 Changed 10 years ago by deyan

  • "The Preview screen really didn't look much different from the editor."

comment:6 Changed 10 years ago by diana

  • Design_owners set to diana
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Imp._owners set to diana

Add a boolean flag in the draw of all text layouts that shows if the book is in preview mode and if so - the caret is not drawn.

comment:7 Changed 10 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

comment:8 Changed 10 years ago by diana

  • Status changed from s2b_design_finished to s2c_design_ok

comment:9 Changed 10 years ago by diana

  • Owner set to diana
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:10 Changed 10 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:11 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to diana
  • Analysis_score changed from 0 to 2
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 2
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 2

Where is your branch???

And when i merged it I had to put some spaces...
And I'll fail it because it makes the selection of the text in preview mode buggy.
Make sure it works in the reader too...

2p

comment:12 Changed 10 years ago by meddle

  • Cc diana added
  • Status changed from s3c_implementation_ok to s1c_analysis_ok

comment:13 Changed 10 years ago by diana

  • Status changed from s1c_analysis_ok to s2a_design_started

Add chech in HotTextElementHelper class if the book is in preview mode not to set the caret and mark poses again.
source code: [7515]

comment:14 Changed 10 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

comment:15 Changed 10 years ago by diana

  • Status changed from s2b_design_finished to s2c_design_ok

comment:16 Changed 10 years ago by diana

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:17 Changed 10 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:18 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 2 to 2.5

I'll have to fail your fix again :(

We tested hard and long time and we have cursor on empty text frames...

2.5p (40m)

comment:19 Changed 10 years ago by todor

  • Summary changed from Text cursor should not be shown in preview mode and reader to Text caret should not be shown in preview mode and reader

comment:20 Changed 10 years ago by deyan

  • Importance set to 60

Batch update from file 0911261.csv

comment:21 Changed 9 years ago by meddle

  • Status changed from s2c_design_ok to closed
  • Resolution set to duplicate

Closing it because of #1717 is the same...

comment:22 Changed 9 years ago by meddle

  • Status changed from closed to s3c_implementation_ok

comment:23 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution changed from duplicate to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.