Newly created frames should be on focus

[deyan]

When you create a frame, it should be selected. For example, you should be able to select text right after inserting it.

[deyan]

User feedback:

• "When trying to create a insert text, there was no shortage in difficulties. First, it created a text box that was unable to be edited. After two or three tries of that, an error message popped up."

[deni]

• Add a new method in ElementView, which finds the view of a child resource of its model by reference - public ElementView getSubView(ResourceRefR4 ref)
• In all logic that create new frames, use this method to find the FrameView of the newly created frame and select it.
• Done for image frames in: [6790]

[meddle]

That fix will lead to code repeating in all the insert-frame logics... May be you should create method that selects a view by it's ResourceRef in the ElementView, instead of this.

Write your name as an owner of the design and implementation and as a reviewer of the analysis and set the ticked to im-fi to us to check both the implementation and the design.

2p (15m)

[deni]

• Selecting newly created frames:
  • Add a new method selectLastElement() in ElementView which selects the lastly added child element of the view's model. This is the last element in its children list.
  • In selectLastElement() check whether the last added element is a frame and if so, set the focus to its content element (so that users are able to write in text frame right after inserting them).
    • It turned out that frames lose focus when they are rotated using the moveable rotation halo. Therefore the focus should be set in mouseReleased of the MouseCapture in FrameRotateHaloButton, too.
  • In all logics that insert new frames, call selectLastElement() on the parent view after the AutoActions that create the frame. These logics are:
    • ImageLogic
    • MediaLogic
    • HotTextLogic
    • CommentLogic
    • BrowserLogic
    • EmbeddedBookLogic
    • HtmlLogic
    • PdfLogic
    • RtfLogic

• Inserting frames in the current edit scope:
  • Currently frames are always inserted as direct children of the page. However, if the current edit scope is a group, they should be inserted in the group.
  • Move selectInsertLocation() and addElement(..) from PageH to ElementH.
  • In all logics that create new frames, make sure that frames are inserted as the current edit scope as a parent.

[deni]

Source code: [6790], [6920]

[mira]

• I don`t think that this is the best way to select the frame with - selectLastElement(). I believe this is higher level logic. Maybe you can keep the reference to the newly created element and select it.
• There is similar code in all logics. Its is best for this to be extracted in a

util method.

• The flash logic insertion is not fixed.
• When inserting a sticky it is not selected and you can not write directly in it.

Merged at [6993].

[6993]

[deyan]

fixed